Issue 10825414: Revert 152013 (broke:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825414: Revert 152013 (broke: (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 152013 (broke: browser_tests on XP Tests (1) XP Tests (dbg)(2) views_unittests on XP Tests (3) XP Tests (dbg)(2) Interactive UI Tests on Interactive Tests (dbg) E.g. Backtrace: RaiseException [0x7C812AFB+82] views::NativeControl::GetAdditionalExStyle [0x0D5D4FB8+1998283] views::NativeControl::GetAdditionalExStyle [0x0D5D430B+1995038] views::NativeControl::GetAdditionalExStyle [0x0D45EC67+465530] views::NativeControl::GetAdditionalExStyle [0x0D435154+294759] views::NativeControl::GetAdditionalExStyle [0x0D434087+290458] views::NativeControl::GetAdditionalExStyle [0x0D45C0F2+454405] RelaunchChromeBrowserWithNewCommandLineIfNeeded [0x02004D8F+1245903] ) - Move more message handlers from NativeWidgetWin to HWNDMessageHandler. http://crbug.com/142962 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832345 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152036

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+176 lines, -387 lines)			Patch
M	ui/views/widget/hwnd_message_handler.h	View	2 chunks	+0 lines, -35 lines	0 comments	Download
M	ui/views/widget/hwnd_message_handler.cc	View	2 chunks	+0 lines, -260 lines	0 comments	Download
M	ui/views/widget/hwnd_message_handler_delegate.h	View	3 chunks	+0 lines, -25 lines	0 comments	Download
M	ui/views/widget/native_widget_win.h	View	3 chunks	+5 lines, -9 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View	14 chunks	+171 lines, -58 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/08/17 04:21:40, Nico wrote:

LGTM

Expand Messages | Collapse Messages