Don't traverse through junctions when recursively deleting on Windows.

runtime/bin/directory_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/directory.h"
 
 #include <errno.h>
 #include <sys/stat.h>
 
 #include "bin/platform.h"
@@ skipping 215 matching lines @@
   DWORD attributes = find_file_data->dwFileAttributes;
   if ((attributes & FILE_ATTRIBUTE_DIRECTORY) != 0) {
     return DeleteDir(find_file_data->cFileName, path, path_length);
   } else {
     return DeleteFile(find_file_data->cFileName, path, path_length);
   }
 }
 
 
 static bool DeleteRecursively(const char* dir_name) {
+  // If the directory is a junction, it's pointing to some other place in the
+  // filesystem that we do not want to recurse into.
+  DWORD attributes = GetFileAttributes(dir_name);
+  if ((attributes != INVALID_FILE_ATTRIBUTES) &&
+      (attributes & FILE_ATTRIBUTE_REPARSE_POINT) != 0) {
+    printf("%s junction\n", dir_name);

[Søren Gjesse, 2012/08/17 07:07:37]

Please remove debug print.

[Mads Ager (google), 2012/08/17 07:08:46]

Remove debug printing.

[Bob Nystrom, 2012/08/20 23:24:32]

Done.

+    // Just delete the junction itself.
+    return RemoveDirectory(dir_name) != 0;
+  }
+
   // Compute full path for the directory currently being deleted.  The
   // path buffer will be used to construct the current path in the
   // recursive traversal. path_length does not always equal
   // strlen(path) but indicates the current prefix of path that is the
   // path of the current directory in the traversal.
   char* path = static_cast<char*>(malloc(MAX_PATH));
   int path_length = 0;
   bool valid = ComputeFullSearchPath(dir_name, path, &path_length);
   if (!valid) {
     free(path);
@@ skipping 145 matching lines @@
   // MoveFile does not allow replacing exising directories. Therefore,
   // if the new_path is currently a directory we need to delete it
   // first.
   if (new_exists == EXISTS) {
     bool success = DeleteRecursively(new_path);
     if (!success) return false;
   }
   DWORD flags = MOVEFILE_WRITE_THROUGH;
   return (MoveFileEx(path, new_path, flags) != 0);
 }