Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 10825410: Update linux host to handle SIGHUP. use it to reload config. (Closed)

Created:
8 years, 4 months ago by Sergey Ulanov
Modified:
8 years, 4 months ago
Reviewers:
Lambros, Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Update linux host to handle SIGHUP. Use it to reload config. Also updated me2me_virtual_host.py to use that signal to reload config (instead of restarting the host), and when requesting the currently running instance of the script to reload the config (instead of SIGUSR1). BUG=120950 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152149

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -137 lines) Patch
A + remoting/host/posix/sighup_listener.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + remoting/host/posix/sighup_listener.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/remoting_me2me_host.cc View 3 chunks +11 lines, -6 lines 0 comments Download
D remoting/host/sighup_listener_mac.h View 1 chunk +0 lines, -22 lines 0 comments Download
D remoting/host/sighup_listener_mac.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +7 lines, -2 lines 0 comments Download
M remoting/tools/me2me_virtual_host.py View 1 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
8 years, 4 months ago (2012-08-17 00:50:10 UTC) #1
Jamie
lgtm
8 years, 4 months ago (2012-08-17 01:17:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10825410/5001
8 years, 4 months ago (2012-08-17 18:28:46 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 19:22:21 UTC) #4
Try job failure for 10825410-5001 on mac for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698