Fix beginSmoothScroll by doing duration computation in ms

beginSmoothScroll tries to do a simple animation for a given length in seconds, specified as a double. To do a half-second animation, it did base::TimeDelta::FromSeconds(0.5). base::TimeDelta::FromSeconds takes an in64, so this silently converts to FromSeconds(0) causing the smooth scroll to do exactly one step and stop.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152186

[piman, 2012-08-17 19:27:01]

lgtm

[piman, 2012-08-17 19:28:28]

http://codereview.chromium.org/10825407/diff/2001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_base.cc (right):

http://codereview.chromium.org/10825407/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_base.cc:25: static const
double kDurationOfNearScrollGestureMs = 150;
Actually, should those be int64s, since that's what
base::TimeDelta::FromMilliseconds takes?

[nduca, 2012-08-17 19:31:59]

Good point, fixing. Thanks

[commit-bot: I haz the power, 2012-08-17 19:42:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/10825407/3003

[piman, 2012-08-17 19:45:44]

http://codereview.chromium.org/10825407/diff/3003/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_base.cc (right):

http://codereview.chromium.org/10825407/diff/3003/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_base.cc:133: double
duration_in_ms;
here too?

[nduca, 2012-08-17 19:51:33]

Man, I suck!

[piman, 2012-08-17 19:53:48]

lgtm

[commit-bot: I haz the power, 2012-08-17 20:09:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/10825407/10001