[Panel refactor] use browserless Panels by default in Dev/Canary

[Panel refactor] use browserless Panels by default in Dev/Canary

Non Dev/Canary builds can use --browserless-panels flag to use refactored Panels.

TBR=yoshiki

BUG=127323
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152100

[jennb, 2012-08-16 19:20:19]

Hi Matt,

Could you review this small change so that I can get OWNERS approval?

Thanks,
Jenn

[Matt Perry, 2012-08-16 20:22:07]

lgtm

http://codereview.chromium.org/10825396/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/tabs/tabs.cc (right):

http://codereview.chromium.org/10825396/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/tabs/tabs.cc:583: channel ==
chrome::VersionInfo::CHANNEL_CANARY) {
You can use channel <= DEV to cover these cases, as well as "trunk" (which is
CHANNEL_UNKNOWN).

[jennb, 2012-08-16 20:42:50]

Thanks, Matt.

http://codereview.chromium.org/10825396/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/tabs/tabs.cc (right):

http://codereview.chromium.org/10825396/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/tabs/tabs.cc:583: channel ==
chrome::VersionInfo::CHANNEL_CANARY) {
On 2012/08/16 20:22:07, Matt Perry wrote:
> You can use channel <= DEV to cover these cases, as well as "trunk" (which is
> CHANNEL_UNKNOWN).

I don't want to include CHANNEL_UNKNOWN. That way, we can still debug issues in
our own builds and compare old-style Panels with refactored Panels behavior.

[Dmitry Titov, 2012-08-16 20:57:56]

lgtm

I bit non-standard to keep the old feature in local builds, but I guess it's all
temporary and we'll kill the old ones soon anyways.

[commit-bot: I haz the power, 2012-08-16 20:59:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10825396/1

[jennb, 2012-08-16 23:21:21]

Completely reworked patch to enable browserless panels by default on
trunk/canary/dev. Replaced previous flag with new --old-panels flag to revert to
using pre-refactor panels.

Updated tests that open panels via extension API to only run if using
browserless panels.

Had to touch a few extra files due to the flag change. PTAL.

Thanks!

[Matt Perry, 2012-08-16 23:33:44]

lgtm

[Dmitry Titov, 2012-08-17 01:02:00]

lgtm too

[commit-bot: I haz the power, 2012-08-17 01:04:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10825396/10002

[commit-bot: I haz the power, 2012-08-17 01:04:46]

Presubmit check for 10825396-10002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/task_manager

Presubmit checks took 1.1s to calculate.

[commit-bot: I haz the power, 2012-08-17 17:25:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10825396/14002