Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 10825389: Fix accessability for web notification tray. (Closed)

Created:
8 years, 4 months ago by stevenjb
Modified:
8 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fix accessability for web notification tray. This makes the system tray the first child so that it is the first tray focused when the status area widget is selected via accessibility. This depends on http://codereview.chromium.org/10823350/ BUG=142506 For ash/ash_strings.grd: TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152135 Reverted: https://chromiumcodereview.appspot.com/10832389 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152487

Patch Set 1 #

Patch Set 2 : Fix asan bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -26 lines) Patch
M ash/ash_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.h View 2 chunks +1 line, -3 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M ash/system/tray/system_tray_bubble.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M ash/system/tray/tray_bubble_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 5 chunks +14 lines, -1 line 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
stevenjb
Relatively small CL now. Ready for review.
8 years, 4 months ago (2012-08-16 17:09:46 UTC) #1
sadrul
LGTM
8 years, 4 months ago (2012-08-17 01:20:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10825389/1
8 years, 4 months ago (2012-08-17 16:33:38 UTC) #3
commit-bot: I haz the power
Presubmit check for 10825389-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-17 16:33:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10825389/1
8 years, 4 months ago (2012-08-17 16:34:40 UTC) #5
commit-bot: I haz the power
Change committed as 152135
8 years, 4 months ago (2012-08-17 19:41:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10825389/8002
8 years, 4 months ago (2012-08-21 00:53:02 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 02:31:54 UTC) #8
Change committed as 152487

Powered by Google App Engine
This is Rietveld 408576698