Use JavaScript runtime semantics when constant folding.

lib/compiler/implementation/operations.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file

[ngeoffray, 2012/08/17 08:32:59]

Maybe change this file to dart_operations.dart?

[floitsch, 2012/09/03 14:34:52]

Done.

 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface Operation {
   final SourceString name;
   bool isUserDefinable();
 }
 
 interface UnaryOperation extends Operation {
   /** Returns [:null:] if it was unable to fold the operation. */
@@ skipping 44 matching lines @@
 }
 
 interface BinaryOperation extends Operation {
   /** Returns [:null:] if it was unable to fold the operation. */
   Constant fold(Constant left, Constant right);
 }
 
 /**
  * Operations that only work if both arguments are integers.
  */
-class BinaryIntOperation implements BinaryOperation {
+class BinaryBitOperation implements BinaryOperation {
   bool isUserDefinable() => true;
-  const BinaryIntOperation();
+  const BinaryBitOperation();
   Constant fold(Constant left, Constant right) {
     if (left.isInt() && right.isInt()) {
       IntConstant leftInt = left;
       IntConstant rightInt = right;
       int resultValue = foldInts(leftInt.value, rightInt.value);
       if (resultValue === null) return null;
       return new IntConstant(resultValue);
     }
     return null;
   }
 
   abstract int foldInts(int left, int right);
 }
 
-class BitOrOperation extends BinaryIntOperation {
+class BitOrOperation extends BinaryBitOperation {
   final SourceString name = const SourceString('|');
   const BitOrOperation();
   int foldInts(int left, int right)  => left | right;
 }
 
-class BitAndOperation extends BinaryIntOperation {
+class BitAndOperation extends BinaryBitOperation {
   final SourceString name = const SourceString('&');
   const BitAndOperation();
   int foldInts(int left, int right) => left & right;
 }
 
-class BitXorOperation extends BinaryIntOperation {
+class BitXorOperation extends BinaryBitOperation {
   final SourceString name = const SourceString('^');
   const BitXorOperation();
   int foldInts(int left, int right) => left ^ right;
 }
 
-class ShiftLeftOperation extends BinaryIntOperation {
+class ShiftLeftOperation extends BinaryBitOperation {
   final SourceString name = const SourceString('<<');
   const ShiftLeftOperation();
   int foldInts(int left, int right) {
     // TODO(floitsch): find a better way to guard against excessive shifts to
     // the left.
     if (right > 100 || right < 0) return null;
     return left << right;
   }
 }
 
-class ShiftRightOperation extends BinaryIntOperation {
+class ShiftRightOperation extends BinaryBitOperation {
   final SourceString name = const SourceString('>>');
   const ShiftRightOperation();
   int foldInts(int left, int right) {
     if (right < 0) return null;
     return left >> right;
   }
 }
 
 class BinaryBoolOperation implements BinaryOperation {
   bool isUserDefinable() => false;
   const BinaryBoolOperation();
   Constant fold(Constant left, Constant right) {
     if (left.isBool() && right.isBool()) {
       BoolConstant leftBool = left;
       BoolConstant rightBool = right;
       bool resultValue = foldBools(leftBool.value, rightBool.value);
       return new BoolConstant(resultValue);
     }
     return null;
   }
 
   abstract bool foldBools(bool left, bool right);
 }
 
-class BooleanAnd extends BinaryBoolOperation {
+class BooleanAndOperation extends BinaryBoolOperation {
   final SourceString name = const SourceString('&&');
-  const BooleanAnd();
+  const BooleanAndOperation();
   bool foldBools(bool left, bool right) => left && right;
 }
 
-class BooleanOr extends BinaryBoolOperation {
+class BooleanOrOperation extends BinaryBoolOperation {
   final SourceString name = const SourceString('||');
-  const BooleanOr();
+  const BooleanOrOperation();
   bool foldBools(bool left, bool right) => left || right;
 }
 
 class ArithmeticNumOperation implements BinaryOperation {
   bool isUserDefinable() => true;
   const ArithmeticNumOperation();
   Constant fold(Constant left, Constant right) {
     if (left.isNum() && right.isNum()) {
       NumConstant leftNum = left;
       NumConstant rightNum = right;
@@ skipping 136 matching lines @@
       return null;
     }
     return new BoolConstant(left == right);
   }
 }
 
 class IdentityOperation implements BinaryOperation {
   final SourceString name = const SourceString('===');
   bool isUserDefinable() => false;
   const IdentityOperation();
-  Constant fold(Constant left, Constant right) {
+  BoolConstant fold(Constant left, Constant right) {
     // In order to preserve runtime semantics which says that NaN !== NaN don't
     // constant fold NaN === NaN. Otherwise the output depends on inlined
     // variables and other optimizations.
     if (left.isNaN() && right.isNaN()) return null;
     return new BoolConstant(left == right);
   }
 }
+
+interface FoldingOperations {
+  BinaryOperation get add();
+  BinaryOperation get bitAnd();
+  UnaryOperation get bitNot();
+  BinaryOperation get bitOr();
+  BinaryOperation get bitXor();
+  BinaryOperation get booleanAnd();
+  BinaryOperation get booleanOr();
+  BinaryOperation get divide();
+  BinaryOperation get equal();
+  BinaryOperation get greaterEqual();
+  BinaryOperation get greater();
+  BinaryOperation get identity();
+  BinaryOperation get lessEqual();
+  BinaryOperation get less();
+  BinaryOperation get modulo();
+  BinaryOperation get multiply();
+  UnaryOperation get negate();
+  UnaryOperation get not();
+  BinaryOperation get shiftLeft();
+  BinaryOperation get shiftRight();
+  BinaryOperation get subtract();
+  BinaryOperation get truncatingDivide();
+}
+
+/** Folding operations following the Dart semantics. */
+class DartFoldingOperations implements FoldingOperations {
+  final add = const AddOperation();
+  final bitAnd = const BitAndOperation();
+  final bitNot = const BitNotOperation();
+  final bitOr = const BitOrOperation();
+  final bitXor = const BitXorOperation();
+  final booleanAnd = const BooleanAndOperation();
+  final booleanOr = const BooleanOrOperation();
+  final divide = const DivideOperation();
+  final equal = const EqualsOperation();
+  final greaterEqual = const GreaterEqualOperation();
+  final greater = const GreaterOperation();
+  final identity = const IdentityOperation();
+  final lessEqual = const LessEqualOperation();
+  final less = const LessOperation();
+  final modulo = const ModuloOperation();
+  final multiply = const MultiplyOperation();
+  final negate = const NegateOperation();
+  final not = const NotOperation();
+  final shiftLeft = const ShiftLeftOperation();
+  final shiftRight = const ShiftRightOperation();
+  final subtract = const SubtractOperation();
+  final truncatingDivide = const TruncatingDivideOperation();
+
+  const DartFoldingOperations();
+}