Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: src/hydrogen.h

Issue 10825384: Fix accessor lookup in crankshaft. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review feedback. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index 00fe92ffb737c0ecc9918021a6d33a5af8503f13..b4e04f31bb957aecdacbea3abb0d7178cf77b35f 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -1132,15 +1132,6 @@ class HGraphBuilder: public AstVisitor {
bool is_store,
bool* has_side_effects);
- // Tries to find a JavaScript accessor of the given name in the prototype
- // chain starting at the given map. Return true iff there is one, including
- // the corresponding AccessorPair plus its holder (which could be null when
- // the accessor is found directly in the given map).
- bool LookupAccessorPair(Handle<Map> map,
- Handle<String> name,
- Handle<AccessorPair>* accessors,
- Handle<JSObject>* holder);
-
HLoadNamedField* BuildLoadNamedField(HValue* object,
Handle<Map> map,
LookupResult* result,
@@ -1150,7 +1141,7 @@ class HGraphBuilder: public AstVisitor {
Property* expr);
HInstruction* BuildCallGetter(HValue* object,
Handle<Map> map,
- Handle<AccessorPair> accessors,
+ Handle<JSFunction> getter,
Handle<JSObject> holder);
HInstruction* BuildLoadNamedMonomorphic(HValue* object,
Handle<String> name,
@@ -1177,7 +1168,7 @@ class HGraphBuilder: public AstVisitor {
HInstruction* BuildCallSetter(HValue* object,
HValue* value,
Handle<Map> map,
- Handle<AccessorPair> accessors,
+ Handle<JSFunction> setter,
Handle<JSObject> holder);
HInstruction* BuildStoreNamedMonomorphic(HValue* object,
Handle<String> name,
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698