Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: test/mjsunit/object-define-property.js

Issue 10825384: Fix accessor lookup in crankshaft. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review feedback. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1154 matching lines...) Expand 10 before | Expand all | Expand 10 after
1165 { get: getter, set: undefined, configurable: true }); 1165 { get: getter, set: undefined, configurable: true });
1166 1166
1167 exception = false; 1167 exception = false;
1168 try { 1168 try {
1169 testSetterOnProtoStrict(obj3); 1169 testSetterOnProtoStrict(obj3);
1170 } catch (e) { 1170 } catch (e) {
1171 exception = true; 1171 exception = true;
1172 assertTrue(/which has only a getter/.test(e)); 1172 assertTrue(/which has only a getter/.test(e));
1173 } 1173 }
1174 assertTrue(exception); 1174 assertTrue(exception);
1175
1176 // Test assignment to a getter-only property on the prototype chain. This makes
1177 // sure that crankshaft re-checks its assumptions and doesn't rely only on type
1178 // feedback (which would be monomorphic here).
1179
1180 function Assign(o) {
1181 o.blubb = 123;
1182 }
1183
1184 function C() {}
1185
1186 Assign(new C);
1187 Assign(new C);
1188 %OptimizeFunctionOnNextCall(Assign);
1189 Object.defineProperty(C.prototype, "blubb", {get: function() { return -42; }});
1190 Assign(new C);
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698