Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/hydrogen.h

Issue 10825384: Fix accessor lookup in crankshaft. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review feedback. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1114 matching lines...) Expand 10 before | Expand all | Expand 10 after
1125 1125
1126 HValue* HandleKeyedElementAccess(HValue* obj, 1126 HValue* HandleKeyedElementAccess(HValue* obj,
1127 HValue* key, 1127 HValue* key,
1128 HValue* val, 1128 HValue* val,
1129 Expression* expr, 1129 Expression* expr,
1130 BailoutId ast_id, 1130 BailoutId ast_id,
1131 int position, 1131 int position,
1132 bool is_store, 1132 bool is_store,
1133 bool* has_side_effects); 1133 bool* has_side_effects);
1134 1134
1135 // Tries to find a JavaScript accessor of the given name in the prototype
1136 // chain starting at the given map. Return true iff there is one, including
1137 // the corresponding AccessorPair plus its holder (which could be null when
1138 // the accessor is found directly in the given map).
1139 bool LookupAccessorPair(Handle<Map> map,
1140 Handle<String> name,
1141 Handle<AccessorPair>* accessors,
1142 Handle<JSObject>* holder);
1143
1144 HLoadNamedField* BuildLoadNamedField(HValue* object, 1135 HLoadNamedField* BuildLoadNamedField(HValue* object,
1145 Handle<Map> map, 1136 Handle<Map> map,
1146 LookupResult* result, 1137 LookupResult* result,
1147 bool smi_and_map_check); 1138 bool smi_and_map_check);
1148 HInstruction* BuildLoadNamedGeneric(HValue* object, 1139 HInstruction* BuildLoadNamedGeneric(HValue* object,
1149 Handle<String> name, 1140 Handle<String> name,
1150 Property* expr); 1141 Property* expr);
1151 HInstruction* BuildCallGetter(HValue* object, 1142 HInstruction* BuildCallGetter(HValue* object,
1152 Handle<Map> map, 1143 Handle<Map> map,
1153 Handle<AccessorPair> accessors, 1144 Handle<JSFunction> getter,
1154 Handle<JSObject> holder); 1145 Handle<JSObject> holder);
1155 HInstruction* BuildLoadNamedMonomorphic(HValue* object, 1146 HInstruction* BuildLoadNamedMonomorphic(HValue* object,
1156 Handle<String> name, 1147 Handle<String> name,
1157 Property* expr, 1148 Property* expr,
1158 Handle<Map> map); 1149 Handle<Map> map);
1159 HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue* key); 1150 HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue* key);
1160 HInstruction* BuildExternalArrayElementAccess( 1151 HInstruction* BuildExternalArrayElementAccess(
1161 HValue* external_elements, 1152 HValue* external_elements,
1162 HValue* checked_key, 1153 HValue* checked_key,
1163 HValue* val, 1154 HValue* val,
1164 HValue* dependency, 1155 HValue* dependency,
1165 ElementsKind elements_kind, 1156 ElementsKind elements_kind,
1166 bool is_store); 1157 bool is_store);
1167 1158
1168 HInstruction* BuildStoreNamedField(HValue* object, 1159 HInstruction* BuildStoreNamedField(HValue* object,
1169 Handle<String> name, 1160 Handle<String> name,
1170 HValue* value, 1161 HValue* value,
1171 Handle<Map> map, 1162 Handle<Map> map,
1172 LookupResult* lookup, 1163 LookupResult* lookup,
1173 bool smi_and_map_check); 1164 bool smi_and_map_check);
1174 HInstruction* BuildStoreNamedGeneric(HValue* object, 1165 HInstruction* BuildStoreNamedGeneric(HValue* object,
1175 Handle<String> name, 1166 Handle<String> name,
1176 HValue* value); 1167 HValue* value);
1177 HInstruction* BuildCallSetter(HValue* object, 1168 HInstruction* BuildCallSetter(HValue* object,
1178 HValue* value, 1169 HValue* value,
1179 Handle<Map> map, 1170 Handle<Map> map,
1180 Handle<AccessorPair> accessors, 1171 Handle<JSFunction> setter,
1181 Handle<JSObject> holder); 1172 Handle<JSObject> holder);
1182 HInstruction* BuildStoreNamedMonomorphic(HValue* object, 1173 HInstruction* BuildStoreNamedMonomorphic(HValue* object,
1183 Handle<String> name, 1174 Handle<String> name,
1184 HValue* value, 1175 HValue* value,
1185 Handle<Map> map); 1176 Handle<Map> map);
1186 HInstruction* BuildStoreKeyedGeneric(HValue* object, 1177 HInstruction* BuildStoreKeyedGeneric(HValue* object,
1187 HValue* key, 1178 HValue* key,
1188 HValue* value); 1179 HValue* value);
1189 1180
1190 HValue* BuildContextChainWalk(Variable* var); 1181 HValue* BuildContextChainWalk(Variable* var);
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1466 const char* filename_; 1457 const char* filename_;
1467 HeapStringAllocator string_allocator_; 1458 HeapStringAllocator string_allocator_;
1468 StringStream trace_; 1459 StringStream trace_;
1469 int indent_; 1460 int indent_;
1470 }; 1461 };
1471 1462
1472 1463
1473 } } // namespace v8::internal 1464 } } // namespace v8::internal
1474 1465
1475 #endif // V8_HYDROGEN_H_ 1466 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698