Issue 10825374: Move up flimflam cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825374: Move up flimflam cleanup (Closed)

Created:
8 years, 4 months ago by krisr

Modified:
8 years, 4 months ago

Reviewers:
stanleyw, Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move up flimflam cleanup TEST=Ran it BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151774

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/pyautolib/chromeos_network.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

8 years, 4 months ago (2012-08-15 22:35:02 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10825374/diff/1/chrome/test/pyautolib/...
File chrome/test/pyautolib/chromeos_network.py (right):

https://chromiumcodereview.appspot.com/10825374/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/chromeos_network.py:137:
self.CleanupFlimflamDirsOnChromeOS()
Move it before the comment.

Expand Messages | Collapse Messages