Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10825352: Change picker model API to allow less notification messages (Closed)

Created:
8 years, 4 months ago by groby-ooo-7-16
Modified:
8 years, 4 months ago
Reviewers:
Nico, Greg Billock
CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org
Visibility:
Public.

Description

Change picker model API to allow less notification messages Removed an unneeded function in the process TBR=thakis@chromium.org BUG=137085 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151832

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -68 lines) Patch
M chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_model.h View 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_model.cc View 4 chunks +10 lines, -20 lines 1 comment Download
M chrome/browser/ui/intents/web_intent_picker_model_unittest.cc View 3 chunks +23 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
groby-ooo-7-16
8 years, 4 months ago (2012-08-14 23:55:42 UTC) #1
Greg Billock
lgtm http://codereview.chromium.org/10825352/diff/1/chrome/browser/ui/intents/web_intent_picker_model.cc File chrome/browser/ui/intents/web_intent_picker_model.cc (right): http://codereview.chromium.org/10825352/diff/1/chrome/browser/ui/intents/web_intent_picker_model.cc#newcode95 chrome/browser/ui/intents/web_intent_picker_model.cc:95: suggested_extensions_.insert(suggested_extensions_.end(), Should we call it "set" and just ...
8 years, 4 months ago (2012-08-15 17:05:07 UTC) #2
groby-ooo-7-16
Pondering the rename. I might do some more cleanup on this anyways... Meanwhile, getting the ...
8 years, 4 months ago (2012-08-15 21:58:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10825352/1
8 years, 4 months ago (2012-08-15 21:59:20 UTC) #4
commit-bot: I haz the power
Try job failure for 10825352-1 (retry) on mac_rel for step "media_unittests". It's a second try, ...
8 years, 4 months ago (2012-08-15 23:11:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10825352/1
8 years, 4 months ago (2012-08-16 00:09:31 UTC) #6
commit-bot: I haz the power
Change committed as 151832
8 years, 4 months ago (2012-08-16 02:33:10 UTC) #7
Nico
8 years, 4 months ago (2012-08-16 02:51:23 UTC) #8
If you TBR changes (regular changes that is), please add the person you're
TBR'ing to as a reviewer.

(lgtm)

Powered by Google App Engine
This is Rietveld 408576698