Issue 10825351: Revert 151581 - Eliminate the 'build_ppapi_ipc_proxy_untrusted' build flag for untrusted PPAPI prox…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825351: Revert 151581 - Eliminate the 'build_ppapi_ipc_proxy_untrusted' build flag for untrusted PPAPI prox… (Closed)

Created:
8 years, 4 months ago by bbudge

Modified:
8 years, 4 months ago

Reviewers:
bbudge

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 151581 - Eliminate the 'build_ppapi_ipc_proxy_untrusted' build flag for untrusted PPAPI proxy builds. This CL removes our custom GYP flag and modifies the build so both the SRPC and IPC proxies are built side by side. In addition, NaClBrowser now checks the '--enable-nacl-ipc-proxy' flag to determine which IRT to load. The IPC proxy's name is of the form 'nacl_ipc_irt_*'. BUG=116317 TEST=builds and runs NaCl apps with --enable-nacl-ipc-proxy Review URL: https://chromiumcodereview.appspot.com/10836220 TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151584

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -72 lines)			Patch
M	build/all.gyp	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	build/common.gypi	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/nacl_host/nacl_browser.cc	View	4 chunks	+8 lines, -17 lines	0 comments	Download
M	chrome/nacl.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/native_client/native_client.gyp	View	3 chunks	+16 lines, -6 lines	0 comments	Download
D	ppapi/ppapi_ipc_proxy_untrusted.gyp	View	1 chunk	+0 lines, -49 lines	0 comments	Download
A +	ppapi/ppapi_proxy_untrusted.gyp	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages