Add name and library to selectors.

lib/compiler/implementation/ssa/optimize.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface OptimizationPhase {
   String get name();
   void visitGraph(HGraph graph);
 }
 
 class SsaOptimizerTask extends CompilerTask {
@@ skipping 188 matching lines @@
     if (!input.canBePrimitive() && !node.getter && !node.setter) {
       bool transformToDynamicInvocation = true;
       if (input.canBeNull()) {
         // Check if the method exists on Null. If yes we must not transform
         // the static interceptor call to a dynamic invocation.
         // TODO(floitsch): get a list of methods that exist on 'null' and only
         // bail out on them.
         transformToDynamicInvocation = false;
       }
       if (transformToDynamicInvocation) {
-        return fromInterceptorToDynamicInvocation(node, node.name);
+        return fromInterceptorToDynamicInvocation(node, node.selector);
       }
     }
 
     return node;
   }
 
   HInstruction visitInvokeDynamic(HInvokeDynamic node) {
     HType receiverType = node.receiver.propagatedType;
     if (receiverType.isExact()) {
       HBoundedType type = receiverType;
       Element element = type.lookupMember(node.name);
       // TODO(ngeoffray): Also fold if it's a getter or variable.
       if (element != null && element.isFunction()) {
         if (node.selector.applies(element, compiler)) {
           FunctionElement method = element;
           FunctionSignature parameters = method.computeSignature(compiler);
           if (parameters.optionalParameterCount == 0) {
             node.element = element;
           }
           // TODO(ngeoffray): If the method has optional parameters,
           // we should pass the default values here.
         }
       }
     }
     return node;
   }
 
-  HInstruction fromInterceptorToDynamicInvocation(
-      HInvokeStatic node, SourceString methodName) {
+  HInstruction fromInterceptorToDynamicInvocation(HInvokeStatic node,
+                                                  Selector selector) {
     HBoundedType type = node.inputs[1].propagatedType;
     HInvokeDynamicMethod result = new HInvokeDynamicMethod(
-        node.selector,
-        methodName,
+        selector,
+        selector.name,
         node.inputs.getRange(1, node.inputs.length - 1));
     if (type.isExact()) {
       HBoundedType concrete = type;
-      result.element = concrete.lookupMember(methodName);
+      result.element = concrete.lookupMember(selector.name);
     }
     return result;
   }
 
   HInstruction visitBoundsCheck(HBoundsCheck node) {
     int tryGetIntConstantValue(HInstruction instruction, String errorMessage) {
       // Tests whether an [HInstruction] is a constant.
       // If it is a constant, and not an int constant, it fails.
       // If it's an int constant it returns the value.
       // Otherwise it's not a constant, and this function returns null.
@@ skipping 38 matching lines @@
         return !constantInstruction.constant.isInt();
       });
       node.alwaysFalse = true;
     }
     return node;
   }
 
 
   HInstruction visitIndex(HIndex node) {
     if (!node.receiver.canBePrimitive()) {
-      SourceString methodName = Elements.constructOperatorName(
-          const SourceString('operator'), const SourceString('[]'));
-      return fromInterceptorToDynamicInvocation(node, methodName);
+      Selector selector = new Selector.index();
+      return fromInterceptorToDynamicInvocation(node, selector);
     }
     return node;
   }
 
   HInstruction visitIndexAssign(HIndexAssign node) {
     if (!node.receiver.canBePrimitive()) {
-      SourceString methodName = Elements.constructOperatorName(
-          const SourceString('operator'), const SourceString('[]='));
-      return fromInterceptorToDynamicInvocation(node, methodName);
+      Selector selector = new Selector.indexSet();
+      return fromInterceptorToDynamicInvocation(node, selector);
     }
     return node;
   }
 
   HInstruction visitInvokeBinary(HInvokeBinary node) {
     HInstruction left = node.left;
     HInstruction right = node.right;
     if (left is HConstant && right is HConstant) {
       BinaryOperation operation = node.operation;
       HConstant op1 = left;
       HConstant op2 = right;
       Constant folded = operation.fold(op1.constant, op2.constant);
       if (folded !== null) return graph.addConstant(folded);
     }
 
     if (!left.canBePrimitive()
         && node.operation.isUserDefinable()
         // The equals operation is being optimized in visitEquals.
         && node.operation !== const EqualsOperation()) {
-      SourceString methodName = Elements.constructOperatorName(
-          const SourceString('operator'), node.operation.name);
-      return fromInterceptorToDynamicInvocation(node, methodName);
+      Selector selector = new Selector.binaryOperator(node.operation.name);
+      return fromInterceptorToDynamicInvocation(node, selector);
     }
     return node;
   }
 
   bool allUsersAreBoolifies(HInstruction instruction) {
     List<HInstruction> users = instruction.usedBy;
     int length = users.length;
     for (int i = 0; i < length; i++) {
       if (users[i] is! HBoolify) return false;
     }
@@ skipping 293 matching lines @@
       instruction = instruction.accept(this);
       instruction = next;
     }
   }
 
   HBoundsCheck insertBoundsCheck(HInstruction node,
                                  HInstruction receiver,
                                  HInstruction index) {
     HStatic interceptor = new HStatic(lengthInterceptor);
     node.block.addBefore(node, interceptor);
+    Selector selector = new Selector.call(
+        lengthInterceptor.name,
+        lengthInterceptor.getLibrary(),  // TODO(kasperl): Wrong.
+        0);
     HInvokeInterceptor length = new HInvokeInterceptor(
-        Selector.INVOCATION_0,
+        selector,
         const SourceString("length"),
         <HInstruction>[interceptor, receiver],
         getter: true);
     length.propagatedType = HType.INTEGER;
     node.block.addBefore(node, length);
 
     HBoundsCheck check = new HBoundsCheck(index, length);
     node.block.addBefore(node, check);
     return check;
   }
@@ skipping 641 matching lines @@
       // this type for the field is still a strong signal
       // indicating the expected type of the field.
       field.propagatedType = type;
     } else {
       // If there are no invoked setters we know the type of
       // this field for sure.
       field.guaranteedType = type;
     }
   }
 }