Issue 10825333: extensions: Print to stdout on all platform with --pack-extension.

Issue 10825333: extensions: Print to stdout on all platform with --pack-extension. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

extensions: Print to stdout on all platform with --pack-extension. BUG=137454 R=aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151810

Patch Set 3 : rebase and fix nit #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	chrome/browser/extensions/startup_helper.cc	View	1 2	2 chunks	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

https://chromiumcodereview.appspot.com/10825333/diff/1/chrome/browser/extensions/extensions_startup.cc File chrome/browser/extensions/extensions_startup.cc (right): https://chromiumcodereview.appspot.com/10825333/diff/1/chrome/browser/extensions/extensions_startup.cc#newcode16 chrome/browser/extensions/extensions_startup.cc:16: void PrintPackExtensionMessage(const std::string& title, You can remove all the ...

8 years, 4 months ago (2012-08-14 01:32:01 UTC) #1

tfarina

8 years, 4 months ago (2012-08-14 01:48:58 UTC) #2

Aaron Boodman

8 years, 4 months ago (2012-08-15 03:41:43 UTC) #4

lgtm w/ nit

http://codereview.chromium.org/10825333/diff/4001/chrome/browser/extensions/e...
File chrome/browser/extensions/extensions_startup.cc (right):

http://codereview.chromium.org/10825333/diff/4001/chrome/browser/extensions/e...
chrome/browser/extensions/extensions_startup.cc:29:
UTF16ToUTF8(PackExtensionJob::StandardSuccessMessage(crx_path,
Indent is weird here. I think that PackExtensionJob::StandardSuccessMessage
should be on a new line.

Expand Messages | Collapse Messages