Adding unit tests for maximize menu

Adding unit tests for maximize menu


BUG=141635
TEST=Unittest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151604

[Mr4D (OOO till 08-26), 2012-08-13 20:26:14]

As promised. Have a look!

[sky, 2012-08-13 21:17:14]

http://codereview.chromium.org/10825327/diff/1/ash/wm/custom_frame_view_ash_u...
File ash/wm/custom_frame_view_ash_unittest.cc (right):

http://codereview.chromium.org/10825327/diff/1/ash/wm/custom_frame_view_ash_u...
ash/wm/custom_frame_view_ash_unittest.cc:260: TEST_F(CustomFrameViewAshTest,
MaximizeButtonCrashOnExternalShutDown) {
Add a small description as to what each test is testing.

http://codereview.chromium.org/10825327/diff/1/ash/wm/custom_frame_view_ash_u...
ash/wm/custom_frame_view_ash_unittest.cc:282: widget->Close();
Can you make this is a CloseNow() and in all other places.

http://codereview.chromium.org/10825327/diff/1/ash/wm/maximize_bubble_control...
File ash/wm/maximize_bubble_controller.cc (right):

http://codereview.chromium.org/10825327/diff/1/ash/wm/maximize_bubble_control...
ash/wm/maximize_bubble_controller.cc:805: gfx::Point screen_location =
gfx::Screen::GetCursorScreenPoint();
Use the location passed in the event.

[Mr4D (OOO till 08-26), 2012-08-13 23:01:03]

Adressed - Please have another look!

http://codereview.chromium.org/10825327/diff/1/ash/wm/custom_frame_view_ash_u...
File ash/wm/custom_frame_view_ash_unittest.cc (right):

http://codereview.chromium.org/10825327/diff/1/ash/wm/custom_frame_view_ash_u...
ash/wm/custom_frame_view_ash_unittest.cc:260: TEST_F(CustomFrameViewAshTest,
MaximizeButtonCrashOnExternalShutDown) {
On 2012/08/13 21:17:14, sky wrote:
> Add a small description as to what each test is testing.

Done.

http://codereview.chromium.org/10825327/diff/1/ash/wm/custom_frame_view_ash_u...
ash/wm/custom_frame_view_ash_unittest.cc:282: widget->Close();
On 2012/08/13 21:17:14, sky wrote:
> Can you make this is a CloseNow() and in all other places.

Done.

http://codereview.chromium.org/10825327/diff/1/ash/wm/maximize_bubble_control...
File ash/wm/maximize_bubble_controller.cc (right):

http://codereview.chromium.org/10825327/diff/1/ash/wm/maximize_bubble_control...
ash/wm/maximize_bubble_controller.cc:805: gfx::Point screen_location =
gfx::Screen::GetCursorScreenPoint();
Somehow I knew that this would come :). Done.

I have to admit I am still a bit fuzzy about why 
"bounds().Contains(event.location())" does not work directly. I would have
estimated that that should work - but it does not.

[sky, 2012-08-14 00:10:04]

LGTM

[commit-bot: I haz the power, 2012-08-14 00:17:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10825327/5001

[commit-bot: I haz the power, 2012-08-14 04:55:09]

Failed to apply patch for ash/wm/maximize_bubble_controller.cc:
While running patch -p1 --forward --force;
patching file ash/wm/maximize_bubble_controller.cc
Hunk #7 FAILED at 364.
1 out of 16 hunks FAILED -- saving rejects to file
ash/wm/maximize_bubble_controller.cc.rej

[commit-bot: I haz the power, 2012-08-14 05:25:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10825327/5001

[commit-bot: I haz the power, 2012-08-14 05:25:39]

Failed to apply patch for ash/wm/maximize_bubble_controller.cc:
While running patch -p1 --forward --force;
patching file ash/wm/maximize_bubble_controller.cc
Hunk #7 FAILED at 364.
1 out of 16 hunks FAILED -- saving rejects to file
ash/wm/maximize_bubble_controller.cc.rej

[commit-bot: I haz the power, 2012-08-14 14:27:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10825327/5003

[commit-bot: I haz the power, 2012-08-14 16:06:57]

Change committed as 151485

[commit-bot: I haz the power, 2012-08-14 21:05:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10825327/4005

[commit-bot: I haz the power, 2012-08-14 23:33:44]

Change committed as 151604