[Sync] Dont upload an unrecoverable error for missing synced bookmark node

[Sync] Dont upload an unrecoverable error for missing synced bookmark node

We were uploading when failing to associate the synced bookmarks node,
regardless of whether we expected it or not. Now we do the upload
at a layer above, where we know whether we care or not.

BUG=142387
TEST=Signing into sync on an account with no mobile devices should not
trigger an unrecoverable error upload.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151356

[Nicolas Zea, 2012-08-13 19:14:46]

PTAL, the other patch resulted in unnecessary breakpad uploads.

[tim (not reviewing), 2012-08-13 20:04:36]

https://chromiumcodereview.appspot.com/10825325/diff/1/chrome/browser/sync/gl...
File chrome/browser/sync/glue/bookmark_model_associator.cc (right):

https://chromiumcodereview.appspot.com/10825325/diff/1/chrome/browser/sync/gl...
chrome/browser/sync/glue/bookmark_model_associator.cc:390: syncer::SyncError
error;
We don't need this anymore.

https://chromiumcodereview.appspot.com/10825325/diff/1/chrome/browser/sync/gl...
chrome/browser/sync/glue/bookmark_model_associator.cc:419: error =
syncer::SyncError();
Remove

[tim (not reviewing), 2012-08-13 20:04:51]

On 2012/08/13 20:04:36, timsteele wrote:
>
https://chromiumcodereview.appspot.com/10825325/diff/1/chrome/browser/sync/gl...
> File chrome/browser/sync/glue/bookmark_model_associator.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10825325/diff/1/chrome/browser/sync/gl...
> chrome/browser/sync/glue/bookmark_model_associator.cc:390: syncer::SyncError
> error;
> We don't need this anymore.
> 
>
https://chromiumcodereview.appspot.com/10825325/diff/1/chrome/browser/sync/gl...
> chrome/browser/sync/glue/bookmark_model_associator.cc:419: error =
> syncer::SyncError();
> Remove

LGTM once addressed

[commit-bot: I haz the power, 2012-08-13 20:13:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/10825325/3002

[commit-bot: I haz the power, 2012-08-13 21:48:09]

Change committed as 151356