Issue 10825319: [cros] OOBE avatar picker fixes and polishing.

Issue 10825319: [cros] OOBE avatar picker fixes and polishing. (Closed)

Created:
8 years, 4 months ago by Ivan Korotkov

Modified:
8 years, 4 months ago

Reviewers:
xiyuan, ygorshenin1

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] OOBE avatar picker fixes and polishing. *) Profile image spinner visible again. *) Camera snapshot can no longer be taken while initializing. BUG=141274 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151281

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	chrome/browser/resources/chromeos/login/oobe_screen_user_image.js	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/chromeos/user_images_grid.js	View		4 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ygorshenin1

lgtm http://codereview.chromium.org/10825319/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (left): http://codereview.chromium.org/10825319/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js#oldcode289 chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:289: <<<<<<< HEAD ?

8 years, 4 months ago (2012-08-13 14:04:52 UTC) #2

Ivan Korotkov

http://codereview.chromium.org/10825319/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (left): http://codereview.chromium.org/10825319/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js#oldcode289 chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:289: <<<<<<< HEAD On 2012/08/13 14:04:52, ygorshenin1 wrote: > ? ...

8 years, 4 months ago (2012-08-13 14:06:45 UTC) #3

lgtm

Expand Messages | Collapse Messages