Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/browser/ui/views/ash/app_list/extension_app_item.cc

Issue 10825317: Convert banned calls to use Navigate in ash app list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ash/app_list/extension_app_item.cc
diff --git a/chrome/browser/ui/views/ash/app_list/extension_app_item.cc b/chrome/browser/ui/views/ash/app_list/extension_app_item.cc
index 12f2ab08f94ebd74dfa7033ce019a2529a4aeb16..39f6e3379021098d2c571f278846c30c44617ddf 100644
--- a/chrome/browser/ui/views/ash/app_list/extension_app_item.cc
+++ b/chrome/browser/ui/views/ash/app_list/extension_app_item.cc
@@ -12,7 +12,7 @@
#include "chrome/browser/extensions/management_policy.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/views/ash/extension_utils.h"
@@ -167,16 +167,10 @@ void ExtensionAppItem::ShowExtensionOptions() {
if (!extension)
return;
- // TODO(beng): use Navigate()!
- Browser* browser = browser::FindLastActiveWithProfile(profile_);
- if (!browser) {
- browser = new Browser(Browser::CreateParams(profile_));
- browser->window()->Show();
- }
-
- chrome::AddSelectedTabWithURL(browser, extension->options_url(),
+ chrome::NavigateParams params(NULL,
+ extension->options_url(),
content::PAGE_TRANSITION_LINK);
- browser->window()->Activate();
+ chrome::Navigate(&params);
}
void ExtensionAppItem::StartExtensionUninstall() {

Powered by Google App Engine
This is Rietveld 408576698