Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Side by Side Diff: chrome/browser/ui/ash/app_list/search_builder.cc

Issue 10825317: Convert banned calls to use Navigate in ash app list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/app_list/search_builder.h" 5 #include "chrome/browser/ui/ash/app_list/search_builder.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "chrome/browser/autocomplete/autocomplete_controller.h" 10 #include "chrome/browser/autocomplete/autocomplete_controller.h"
11 #include "chrome/browser/autocomplete/autocomplete_input.h" 11 #include "chrome/browser/autocomplete/autocomplete_input.h"
12 #include "chrome/browser/autocomplete/autocomplete_match.h" 12 #include "chrome/browser/autocomplete/autocomplete_match.h"
13 #include "chrome/browser/autocomplete/autocomplete_result.h" 13 #include "chrome/browser/autocomplete/autocomplete_result.h"
14 #include "chrome/browser/autocomplete/extension_app_provider.h" 14 #include "chrome/browser/autocomplete/extension_app_provider.h"
15 #include "chrome/browser/event_disposition.h" 15 #include "chrome/browser/event_disposition.h"
16 #include "chrome/browser/extensions/extension_service.h" 16 #include "chrome/browser/extensions/extension_service.h"
17 #include "chrome/browser/extensions/image_loading_tracker.h" 17 #include "chrome/browser/extensions/image_loading_tracker.h"
18 #include "chrome/browser/profiles/profile.h" 18 #include "chrome/browser/profiles/profile.h"
19 #include "chrome/browser/ui/ash/extension_utils.h" 19 #include "chrome/browser/ui/ash/extension_utils.h"
20 #include "chrome/browser/ui/browser.h" 20 #include "chrome/browser/ui/browser.h"
21 #include "chrome/browser/ui/browser_finder.h" 21 #include "chrome/browser/ui/browser_navigator.h"
22 #include "chrome/browser/ui/browser_tabstrip.h" 22 #include "chrome/browser/ui/browser_tabstrip.h"
23 #include "chrome/common/extensions/extension.h" 23 #include "chrome/common/extensions/extension.h"
24 #include "chrome/common/extensions/extension_icon_set.h" 24 #include "chrome/common/extensions/extension_icon_set.h"
25 #include "chrome/common/url_constants.h" 25 #include "chrome/common/url_constants.h"
26 #include "content/public/browser/user_metrics.h" 26 #include "content/public/browser/user_metrics.h"
27 #include "content/public/browser/web_contents.h" 27 #include "content/public/browser/web_contents.h"
28 #include "grit/generated_resources.h" 28 #include "grit/generated_resources.h"
29 #include "grit/theme_resources.h" 29 #include "grit/theme_resources.h"
30 #include "ui/app_list/app_list_switches.h" 30 #include "ui/app_list/app_list_switches.h"
31 #include "ui/app_list/search_box_model.h" 31 #include "ui/app_list/search_box_model.h"
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 238
239 if (match.type == AutocompleteMatch::EXTENSION_APP) { 239 if (match.type == AutocompleteMatch::EXTENSION_APP) {
240 const extensions::Extension* extension = 240 const extensions::Extension* extension =
241 GetExtensionByURL(profile_, match.destination_url); 241 GetExtensionByURL(profile_, match.destination_url);
242 if (extension) { 242 if (extension) {
243 content::RecordAction( 243 content::RecordAction(
244 content::UserMetricsAction("AppList_ClickOnAppFromSearch")); 244 content::UserMetricsAction("AppList_ClickOnAppFromSearch"));
245 extension_utils::OpenExtension(profile_, extension, event_flags); 245 extension_utils::OpenExtension(profile_, extension, event_flags);
246 } 246 }
247 } else { 247 } else {
248 WindowOpenDisposition disposition =
249 chrome::DispositionFromEventFlags(event_flags);
250 Browser* browser = browser::FindOrCreateTabbedBrowser(profile_);
251
252 if (disposition == CURRENT_TAB) {
253 // If current tab is not NTP, change disposition to NEW_FOREGROUND_TAB.
254 const GURL& url = chrome::GetActiveWebContents(browser) ?
255 chrome::GetActiveWebContents(browser)->GetURL() : GURL();
256 if (!url.SchemeIs(chrome::kChromeUIScheme) ||
257 url.host() != chrome::kChromeUINewTabHost) {
258 disposition = NEW_FOREGROUND_TAB;
259 }
260 }
261
262 // TODO(xiyuan): What should we do for alternate url case? 248 // TODO(xiyuan): What should we do for alternate url case?
263 browser->OpenURL( 249 chrome::NavigateParams params(profile_,
264 content::OpenURLParams(match.destination_url, 250 match.destination_url,
265 content::Referrer(), 251 match.transition);
266 disposition, 252 params.disposition = chrome::DispositionFromEventFlags(event_flags);
267 match.transition, 253 chrome::Navigate(&params);
268 false));
269 } 254 }
270 } 255 }
271 256
272 void SearchBuilder::PopulateFromACResult(const AutocompleteResult& ac_result) { 257 void SearchBuilder::PopulateFromACResult(const AutocompleteResult& ac_result) {
273 results_->DeleteAll(); 258 results_->DeleteAll();
274 for (ACMatches::const_iterator it = ac_result.begin(); 259 for (ACMatches::const_iterator it = ac_result.begin();
275 it != ac_result.end(); 260 it != ac_result.end();
276 ++it) { 261 ++it) {
277 results_->Add(new SearchBuilderResult(profile_, *it)); 262 results_->Add(new SearchBuilderResult(profile_, *it));
278 } 263 }
279 } 264 }
280 265
281 void SearchBuilder::OnResultChanged(bool default_match_changed) { 266 void SearchBuilder::OnResultChanged(bool default_match_changed) {
282 // TODO(xiyuan): Handle default match properly. 267 // TODO(xiyuan): Handle default match properly.
283 const AutocompleteResult& ac_result = controller_->result(); 268 const AutocompleteResult& ac_result = controller_->result();
284 PopulateFromACResult(ac_result); 269 PopulateFromACResult(ac_result);
285 } 270 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/ash/app_list/extension_app_item.cc ('k') | chrome/browser/ui/browser_navigator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698