Convert banned calls to use Navigate in ash app list.

chrome/browser/ui/ash/app_list/extension_app_item.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/app_list/extension_app_item.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 #include "chrome/browser/extensions/management_policy.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/ash/extension_utils.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 #include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image.h"
 
 using extensions::Extension;
@@ skipping 132 matching lines @@
                       gfx::Size(ExtensionIconSet::EXTENSION_ICON_LARGE,
                                 ExtensionIconSet::EXTENSION_ICON_LARGE),
                       ImageLoadingTracker::DONT_CACHE);
 }
 
 void ExtensionAppItem::ShowExtensionOptions() {
   const Extension* extension = GetExtension();
   if (!extension)
     return;
 
-  // TODO(beng): use Navigate()!
-  Browser* browser = browser::FindLastActiveWithProfile(profile_);
-  if (!browser) {
-    browser = new Browser(Browser::CreateParams(profile_));
-    browser->window()->Show();
-  }
-
-  chrome::AddSelectedTabWithURL(browser, extension->options_url(),
+  chrome::NavigateParams params(profile_,
+                                extension->options_url(),
                                 content::PAGE_TRANSITION_LINK);
-  browser->window()->Activate();
+  chrome::Navigate(&params);
 }
 
 void ExtensionAppItem::StartExtensionUninstall() {
   // ExtensionUninstall deletes itself when done or aborted.
   ExtensionUninstaller* uninstaller = new ExtensionUninstaller(profile_,
                                                                extension_id_);
   uninstaller->Run();
 }
 
 void ExtensionAppItem::OnImageLoaded(const gfx::Image& image,
@@ skipping 109 matching lines @@
         LAUNCH_TYPE_FULLSCREEN,
         IDS_APP_CONTEXT_MENU_OPEN_MAXIMIZED);
     context_menu_model_->AddSeparator();
     context_menu_model_->AddItemWithStringId(OPTIONS, IDS_NEW_TAB_APP_OPTIONS);
     context_menu_model_->AddItemWithStringId(UNINSTALL,
                                              IDS_EXTENSIONS_UNINSTALL);
   }
 
   return context_menu_model_.get();
 }