Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 10825315: Revert 150813 - Disable WebNavigationApiTest.Failures for flakiness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <list> 5 #include <list>
6 #include <set> 6 #include <set>
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 ASSERT_TRUE( 417 ASSERT_TRUE(
418 RunExtensionSubtest("webnavigation", "test_referenceFragment.html")) 418 RunExtensionSubtest("webnavigation", "test_referenceFragment.html"))
419 << message_; 419 << message_;
420 } 420 }
421 421
422 IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, SimpleLoad) { 422 IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, SimpleLoad) {
423 ASSERT_TRUE( 423 ASSERT_TRUE(
424 RunExtensionSubtest("webnavigation", "test_simpleLoad.html")) << message_; 424 RunExtensionSubtest("webnavigation", "test_simpleLoad.html")) << message_;
425 } 425 }
426 426
427 //TODO(jochen): Flakily failing after http://crrev.com/150796. 427 IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, Failures) {
428 //IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, Failures) { 428 ASSERT_TRUE(
429 // ASSERT_TRUE( 429 RunExtensionSubtest("webnavigation", "test_failures.html")) << message_;
430 // RunExtensionSubtest("webnavigation", "test_failures.html")) << message_; 430 }
431 //}
432 431
433 IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, FilteredTest) { 432 IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, FilteredTest) {
434 ASSERT_TRUE( 433 ASSERT_TRUE(
435 RunExtensionSubtest("webnavigation", "test_filtered.html")) << message_; 434 RunExtensionSubtest("webnavigation", "test_filtered.html")) << message_;
436 } 435 }
437 436
438 IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, UserAction) { 437 IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, UserAction) {
439 // Wait for the extension to set itself up and return control to us. 438 // Wait for the extension to set itself up and return control to us.
440 ASSERT_TRUE( 439 ASSERT_TRUE(
441 RunExtensionSubtest("webnavigation", "test_userAction.html")) << message_; 440 RunExtensionSubtest("webnavigation", "test_userAction.html")) << message_;
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 test_server()->GetURL("test6"), 618 test_server()->GetURL("test6"),
620 "updateHistory()", 619 "updateHistory()",
621 extension->GetResourceURL("crossProcess/empty.html")); 620 extension->GetResourceURL("crossProcess/empty.html"));
622 621
623 ASSERT_TRUE(RunPageTest( 622 ASSERT_TRUE(RunPageTest(
624 extension->GetResourceURL("test_crossProcess.html").spec())) 623 extension->GetResourceURL("test_crossProcess.html").spec()))
625 << message_; 624 << message_;
626 } 625 }
627 626
628 } // namespace extensions 627 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698