Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10825311: Add a MANUAL_ prefix for browser tests. These tests don't run unless --run-manual is specified. (Closed)

Created:
8 years, 4 months ago by jam
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add a MANUAL_ prefix for browser tests. These tests don't run unless --run-manual is specified. This is helpful so that instead of adding new binaries for each different test suite that runs on its own bots (and so increading build times), we can still keep the tests in the same binaries. Instead, the specific bots would add --run-manual and can pass the test suite names as a command line flag. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151212

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M content/public/test/test_launcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/content_browser_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/test_launcher.cc View 6 chunks +33 lines, -8 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 4 months ago (2012-08-10 23:37:08 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/10825311/diff/1/content/test/test_launcher.cc File content/test/test_launcher.cc (right): http://codereview.chromium.org/10825311/diff/1/content/test/test_launcher.cc#newcode48 content/test/test_launcher.cc:48: static const int kSlowTestTimeoutMultiplier = 5; nit: 'static' ...
8 years, 4 months ago (2012-08-11 06:16:59 UTC) #2
jam
8 years, 4 months ago (2012-08-13 00:45:25 UTC) #3
http://codereview.chromium.org/10825311/diff/1/content/test/test_launcher.cc
File content/test/test_launcher.cc (right):

http://codereview.chromium.org/10825311/diff/1/content/test/test_launcher.cc#...
content/test/test_launcher.cc:48: static const int kSlowTestTimeoutMultiplier =
5;
On 2012/08/11 06:16:59, darin wrote:
> nit: 'static' is redundant w/ anonymous namespace

Done.

Powered by Google App Engine
This is Rietveld 408576698