Add a 'type' property to ExtensionInfo (chrome.management).

Add a 'type' property to ExtensionInfo (chrome.management).

I suggested here (crbug.com/132729#c8) a similar solution, where 'type' is one of 'extension',
'app', or 'theme', and then 'appType' is either 'hosted', 'packaged', or 'platform'.
I thought maybe this would save developers from having to write their own replacement of 'isApp'

BUG=132729
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151552

[Mihai Parparita -not on Chrome, 2012-08-11 00:03:19]

Drive-by

https://chromiumcodereview.appspot.com/10825310/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/management.json (right):

https://chromiumcodereview.appspot.com/10825310/diff/1/chrome/common/extensio...
chrome/common/extensions/api/management.json:61: "enum": ["extension",
"hosted_app", "packaged_app", "platform_app", "theme"]
"platform app" is not the public name we're using. We're calling them "packaged
apps", and the old ones are "legacy packaged apps".

[mitchellwrosen, 2012-08-11 00:06:01]

https://chromiumcodereview.appspot.com/10825310/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/management.json (right):

https://chromiumcodereview.appspot.com/10825310/diff/1/chrome/common/extensio...
chrome/common/extensions/api/management.json:61: "enum": ["extension",
"hosted_app", "packaged_app", "platform_app", "theme"]
On 2012/08/11 00:03:19, Mihai Parparita wrote:
> "platform app" is not the public name we're using. We're calling them
"packaged
> apps", and the old ones are "legacy packaged apps".

s/platform_app/legacy_packaged_app
s/packaged_app/platform_app

?

[asargent_no_longer_on_chrome, 2012-08-14 00:14:57]

LGTM w/ one possible change request (I left a question for Mihai to see if he
agrees)

https://chromiumcodereview.appspot.com/10825310/diff/6001/chrome/common/exten...
File chrome/common/extensions/api/management.json (right):

https://chromiumcodereview.appspot.com/10825310/diff/6001/chrome/common/exten...
chrome/common/extensions/api/management.json:61: "enum": ["extension",
"hosted_app", "new_packaged_app", "legacy_packaged_app", "theme"]
I think we should just use "pacakged_app" instead of "new_packaged_app"
("legacy_packaged_app" seems fine for legacy packaged apps). 

Mihai- do you agree?

[Mihai Parparita -not on Chrome, 2012-08-14 00:22:26]

https://chromiumcodereview.appspot.com/10825310/diff/6001/chrome/common/exten...
File chrome/common/extensions/api/management.json (right):

https://chromiumcodereview.appspot.com/10825310/diff/6001/chrome/common/exten...
chrome/common/extensions/api/management.json:61: "enum": ["extension",
"hosted_app", "new_packaged_app", "legacy_packaged_app", "theme"]
On 2012/08/14 00:14:57, Antony Sargent wrote:
> I think we should just use "pacakged_app" instead of "new_packaged_app"
> ("legacy_packaged_app" seems fine for legacy packaged apps). 
> 
> Mihai- do you agree?

+1 to Antony's suggestion. I've changed my mind since Friday with the following
rationale: this API will be going live at the same time that we'll be launching
new-style packaged apps, so it makes sense to treat them as the default, i.e. no
"new_" prefix.

[commit-bot: I haz the power, 2012-08-14 18:04:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10825310/1006

[commit-bot: I haz the power, 2012-08-14 20:23:03]

Change committed as 151552