Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 10825306: Refresh output cache when setting display mode (Closed)

Created:
8 years, 4 months ago by disher
Modified:
8 years, 4 months ago
Reviewers:
satorux1, Simon Que
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refresh output cache when setting display mode Historically, all the entry-points into the OutputConfigurator needed to refresh their view of the cached output data. This newly-added entry-point doesn't do this which can lead to the cached data becoming stale (since it technically only applies within the context where the corresponding XRRScreenResources are valid). Ideally, no such information would be cached and every attempt to evaluate or change the state of the video outputs would start by requesting this structure. That change is of larger scope and risk, though, so this is the tactical solution to the immediate problem suitable for porting to stable branches. BUG=chromium:140807 TEST=Manually tested that ctrl-F4 and "manage displays" (in chrome://settings) work on a Lumpy the same way with and without this change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151696

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M chromeos/display/output_configurator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/display/output_configurator.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
disher
8 years, 4 months ago (2012-08-10 20:58:49 UTC) #1
disher1
8 years, 4 months ago (2012-08-13 18:23:59 UTC) #2
Simon Que
LGTM
8 years, 4 months ago (2012-08-14 18:30:45 UTC) #3
disher
satorux@ for owners
8 years, 4 months ago (2012-08-14 18:33:59 UTC) #4
satorux1
I'm not qualified to review the code, however, If you add chromeos/display/OWNERS file in a ...
8 years, 4 months ago (2012-08-14 18:42:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/disher@chromium.org/10825306/7001
8 years, 4 months ago (2012-08-15 13:17:23 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 15:41:47 UTC) #7
Change committed as 151696

Powered by Google App Engine
This is Rietveld 408576698