Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10825304: Creating a new directory chrome/renderer/searchbox and moving appropriate code to it. (Closed)

Created:
8 years, 4 months ago by Shishir
Modified:
8 years, 4 months ago
Reviewers:
sreeram, sky, dhollowa
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, gideonwald, sreeram, dominich, Aaron Boodman, David Black, Shishir, brettw-cc_chromium.org, darin-cc_chromium.org, Jered, tonyg
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Creating a new directory chrome/renderer/searchbox and moving searchbox code to it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151175

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing sky from OWNERS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -572 lines) Patch
M chrome/chrome_renderer.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/renderer/searchbox.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/renderer/searchbox.cc View 1 chunk +0 lines, -119 lines 0 comments Download
A chrome/renderer/searchbox/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/renderer/searchbox/searchbox.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/renderer/searchbox/searchbox.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/renderer/searchbox/searchbox_extension.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/renderer/searchbox_extension.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/renderer/searchbox_extension.cc View 1 chunk +0 lines, -330 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Shishir
Moving the searchbox renderer code to a new directory as per discussions with David and ...
8 years, 4 months ago (2012-08-10 19:54:02 UTC) #1
sky
LGTM https://chromiumcodereview.appspot.com/10825304/diff/1/chrome/renderer/searchbox/OWNERS File chrome/renderer/searchbox/OWNERS (right): https://chromiumcodereview.appspot.com/10825304/diff/1/chrome/renderer/searchbox/OWNERS#newcode1 chrome/renderer/searchbox/OWNERS:1: sky@chromium.org I'm trying to limit how many OWNERs ...
8 years, 4 months ago (2012-08-10 22:20:15 UTC) #2
dhollowa
LGTM. Thanks for splitting this out.
8 years, 4 months ago (2012-08-10 22:21:32 UTC) #3
Shishir
https://chromiumcodereview.appspot.com/10825304/diff/1/chrome/renderer/searchbox/OWNERS File chrome/renderer/searchbox/OWNERS (right): https://chromiumcodereview.appspot.com/10825304/diff/1/chrome/renderer/searchbox/OWNERS#newcode1 chrome/renderer/searchbox/OWNERS:1: sky@chromium.org On 2012/08/10 22:20:16, sky wrote: > I'm trying ...
8 years, 4 months ago (2012-08-11 00:06:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shishir@chromium.org/10825304/8001
8 years, 4 months ago (2012-08-11 00:07:20 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-11 01:21:08 UTC) #6 
Change committed as 151175

Powered by Google App Engine
This is Rietveld 408576698