Issue 10825303: Disable 'Save Video As' option for MediaSource and MediaStream URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825303: Disable 'Save Video As' option for MediaSource and MediaStream URLs. (Closed)

Created:
8 years, 4 months ago by acolwell GONE FROM CHROMIUM

Modified:
8 years, 4 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Disable 'Save Video As' option for MediaSource and MediaStream URLs. BUG=141906 TEST=Manual tested w/ normal & Media Source videos. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151151

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	webkit/media/webmediaplayer_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	webkit/media/webmediaplayer_impl.cc	View		4 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10825303/1

8 years, 4 months ago (2012-08-10 20:05:22 UTC) #3

commit-bot: I haz the power

Try job failure for 10825303-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...

8 years, 4 months ago (2012-08-10 21:08:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10825303/1

8 years, 4 months ago (2012-08-10 22:05:22 UTC) #5

Change committed as 151151