Issue 10825284: Make Browser aware of HostDesktopType.

Issue 10825284: Make Browser aware of HostDesktopType. (Closed)

Created:
8 years, 4 months ago by MAD

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make Browser aware of HostDesktopType. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151056

Patch Set 2 : Rephrased a comment. #

Total comments: 2

Patch Set 3 : No need to check for defined(USE_ASH) #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -6 lines)			Patch
	M	chrome/browser/ui/browser.h	View	1	5 chunks	+12 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/browser.cc	View	1 2	4 chunks	+30 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

robertshield

lg https://chromiumcodereview.appspot.com/10825284/diff/1/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): https://chromiumcodereview.appspot.com/10825284/diff/1/chrome/browser/ui/browser.h#newcode179 chrome/browser/ui/browser.h:179: // On which host desktop is the browser ...

8 years, 4 months ago (2012-08-10 14:17:30 UTC) #2

MAD

Thanks! https://chromiumcodereview.appspot.com/10825284/diff/1/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): https://chromiumcodereview.appspot.com/10825284/diff/1/chrome/browser/ui/browser.h#newcode179 chrome/browser/ui/browser.h:179: // On which host desktop is the browser ...

8 years, 4 months ago (2012-08-10 14:55:42 UTC) #3

Ben Goodger (Google)

cool. lgtm. https://chromiumcodereview.appspot.com/10825284/diff/6001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://chromiumcodereview.appspot.com/10825284/diff/6001/chrome/browser/ui/browser.cc#newcode258 chrome/browser/ui/browser.cc:258: #if defined(USE_ASH) && defined(OS_CHROMEOS) OS_CHROMEOS should be ...

8 years, 4 months ago (2012-08-10 15:05:08 UTC) #5

MAD

OK, good to know... Thanks! CQing... https://chromiumcodereview.appspot.com/10825284/diff/6001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://chromiumcodereview.appspot.com/10825284/diff/6001/chrome/browser/ui/browser.cc#newcode258 chrome/browser/ui/browser.cc:258: #if defined(USE_ASH) && ...

8 years, 4 months ago (2012-08-10 15:26:51 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/10825284/9001

8 years, 4 months ago (2012-08-10 15:27:06 UTC) #7

Change committed as 151056

Expand Messages | Collapse Messages