Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10825282: Put PushArgument into the environment instead of raw values. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index fb35605df70c7704f429d4b4f6c3c8189d85b061..a7cc1a655c5a31b6ffbbfab0b730858b291eba02 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -96,7 +96,7 @@ void EffectGraphVisitor::Do(Computation* computation) {
void EffectGraphVisitor::AddInstruction(Instruction* instruction) {
ASSERT(is_open());
- ASSERT(!instruction->IsDefinition());
+ ASSERT(!instruction->IsBind());
ASSERT(!instruction->IsBlockEntry());
DeallocateTempIndex(instruction->InputCount());
if (is_empty()) {
@@ -2687,7 +2687,7 @@ void FlowGraphBuilder::RenameRecursive(BlockEntryInstr* block_entry,
// 2c. Handle pushed argument.
PushArgumentInstr* push = current->AsPushArgument();
if (push != NULL) {
- env->Add(push->value());
+ env->Add(new UseVal(push));
}
}

Powered by Google App Engine
This is Rietveld 408576698