Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10825282: Put PushArgument into the environment instead of raw values. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 0ad84753773bb24ea52e8655b33a0893a560f72b..502e430be62218d56a48422279b2a65ceda1ba67 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -1768,15 +1768,13 @@ void DoubleBinaryOpComp::EmitNativeCode(FlowGraphCompiler* compiler) {
PcDescriptors::kOther);
// Newly allocated object is now in the result register (RAX).
ASSERT(result == EAX);
- __ popl(right);
- __ popl(left);
+ __ movl(right, Address(ESP, 0));
+ __ movl(left, Address(ESP, kWordSize));
Label* deopt = compiler->AddDeoptStub(instance_call()->deopt_id(),
instance_call()->token_pos(),
instance_call()->try_index(),
- kDeoptDoubleBinaryOp,
- left,
- right);
+ kDeoptDoubleBinaryOp);
// Binary operation of two Smi's produces a Smi not a double.
__ movl(temp, left);
@@ -1796,6 +1794,8 @@ void DoubleBinaryOpComp::EmitNativeCode(FlowGraphCompiler* compiler) {
}
__ movsd(FieldAddress(result, Double::value_offset()), XMM0);
+
+ __ Drop(2);
}

Powered by Google App Engine
This is Rietveld 408576698