Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: webkit/media/webmediaplayer_impl.h

Issue 10825280: Merge Pipeline's kError state with kStopped: a baby step towards bringing sanity to shutdown. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: maybe this time Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player. 5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player.
6 // It contains Pipeline which is the actual media player pipeline, it glues 6 // It contains Pipeline which is the actual media player pipeline, it glues
7 // the media player pipeline, data source, audio renderer and renderer. 7 // the media player pipeline, data source, audio renderer and renderer.
8 // Pipeline would creates multiple threads and access some public methods 8 // Pipeline would creates multiple threads and access some public methods
9 // of this class, so we need to be extra careful about concurrent access of 9 // of this class, so we need to be extra careful about concurrent access of
10 // methods and members. 10 // methods and members.
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 WebKit::WebMediaPlayer::NetworkState network_state_; 277 WebKit::WebMediaPlayer::NetworkState network_state_;
278 WebKit::WebMediaPlayer::ReadyState ready_state_; 278 WebKit::WebMediaPlayer::ReadyState ready_state_;
279 279
280 // Keep a list of buffered time ranges. 280 // Keep a list of buffered time ranges.
281 WebKit::WebTimeRanges buffered_; 281 WebKit::WebTimeRanges buffered_;
282 282
283 // Message loops for posting tasks between Chrome's main thread. Also used 283 // Message loops for posting tasks between Chrome's main thread. Also used
284 // for DCHECKs so methods calls won't execute in the wrong thread. 284 // for DCHECKs so methods calls won't execute in the wrong thread.
285 MessageLoop* main_loop_; 285 MessageLoop* main_loop_;
286 286
287 // A collection of filters.
288 scoped_ptr<media::FilterCollection> filter_collection_; 287 scoped_ptr<media::FilterCollection> filter_collection_;
289
290 // The media pipeline and a bool tracking whether we have started it yet.
291 //
292 // TODO(scherkus): replace |started_| with a pointer check for |pipeline_| and
293 // have WebMediaPlayerImpl return the default values to WebKit instead of
294 // relying on Pipeline to take care of default values.
295 scoped_refptr<media::Pipeline> pipeline_; 288 scoped_refptr<media::Pipeline> pipeline_;
296 bool started_;
297 289
298 // The currently selected key system. Empty string means that no key system 290 // The currently selected key system. Empty string means that no key system
299 // has been selected. 291 // has been selected.
300 WebKit::WebString current_key_system_; 292 WebKit::WebString current_key_system_;
301 293
302 scoped_ptr<media::MessageLoopFactory> message_loop_factory_; 294 scoped_ptr<media::MessageLoopFactory> message_loop_factory_;
303 295
304 // Playback state. 296 // Playback state.
305 // 297 //
306 // TODO(scherkus): we have these because Pipeline favours the simplicity of a 298 // TODO(scherkus): we have these because Pipeline favours the simplicity of a
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 339
348 // The decryptor that manages decryption keys and decrypts encrypted frames. 340 // The decryptor that manages decryption keys and decrypts encrypted frames.
349 ProxyDecryptor decryptor_; 341 ProxyDecryptor decryptor_;
350 342
351 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl); 343 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
352 }; 344 };
353 345
354 } // namespace webkit_media 346 } // namespace webkit_media
355 347
356 #endif // WEBKIT_MEDIA_WEBMEDIAPLAYER_IMPL_H_ 348 #endif // WEBKIT_MEDIA_WEBMEDIAPLAYER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698