Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 10825275: Clean-up inline members of nested classes (ipc/) (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
Reviewers:
dmac
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Clean-up inline members of nested classes (ipc/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ipc/ipc_channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
8 years, 4 months ago (2012-08-09 13:53:52 UTC) #1
dmac
On 2012/08/09 13:53:52, hans wrote: LGTM
8 years, 4 months ago (2012-08-09 16:22:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10825275/1
8 years, 4 months ago (2012-08-09 17:56:04 UTC) #3
commit-bot: I haz the power
Try job failure for 10825275-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-09 19:09:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10825275/1
8 years, 4 months ago (2012-08-09 19:11:14 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 20:39:15 UTC) #6
Change committed as 150891

Powered by Google App Engine
This is Rietveld 408576698