Clean-up inline members of nested classes (base/)

base/values.cc

Index: base/values.cc
diff --git a/base/values.cc b/base/values.cc
index 1ccc9ec4a13755fab4115b20303be9872896f9b0..868a745c75050ac76ff8ea969b403e042a8d49c2 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -750,6 +750,17 @@ void DictionaryValue::Swap(DictionaryValue* other) {
   dictionary_.swap(other->dictionary_);
 }
 
+DictionaryValue::key_iterator::key_iterator(ValueMap::const_iterator itr) {
+  itr_ = itr;
+}
+
+DictionaryValue::key_iterator::key_iterator(const key_iterator& rhs) {
+  itr_ = rhs.itr_;
+}
+
+DictionaryValue::Iterator::Iterator(const DictionaryValue& target)
+    : target_(target), it_(target.dictionary_.begin()) {}

[jar (doing other things), 2012/08/09 16:30:27]

nit: one initializer per line, now that you wrapped the line (despite the fact
that the header file had this wrong).

[hans, 2012/08/09 18:28:48]

Done.

+
 DictionaryValue* DictionaryValue::DeepCopy() const {
   DictionaryValue* result = new DictionaryValue;