Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 10825264: Consolidate volume control code. (Closed)

Created:
8 years, 4 months ago by jennyz
Modified:
8 years, 4 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Consolidate volume_control_delegate and sysmte_tray_delegate BUG=115936 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151607

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and VolumeControlDelegate only accesible via SystemTrayDelegate. #

Total comments: 4

Patch Set 3 : Rebase + Fix virutal function name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -105 lines) Patch
M ash/accelerators/accelerator_controller.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 1 2 2 chunks +6 lines, -11 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 6 chunks +18 lines, -7 lines 0 comments Download
M ash/system/audio/tray_volume.cc View 1 2 10 chunks +23 lines, -19 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 2 4 chunks +47 lines, -22 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
M ash/volume_control_delegate.h View 1 chunk +12 lines, -0 lines 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 3 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 6 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jennyz
8 years, 4 months ago (2012-08-08 23:11:23 UTC) #1
sadrul
http://codereview.chromium.org/10825264/diff/1/ash/system/tray/system_tray_item.h File ash/system/tray/system_tray_item.h (right): http://codereview.chromium.org/10825264/diff/1/ash/system/tray/system_tray_item.h#newcode71 ash/system/tray/system_tray_item.h:71: virtual void UpdateAfterAshInit(); I don't think we should have ...
8 years, 4 months ago (2012-08-09 18:05:33 UTC) #2
jennyz
http://codereview.chromium.org/10825264/diff/1/ash/system/tray/system_tray_item.h File ash/system/tray/system_tray_item.h (right): http://codereview.chromium.org/10825264/diff/1/ash/system/tray/system_tray_item.h#newcode71 ash/system/tray/system_tray_item.h:71: virtual void UpdateAfterAshInit(); On 2012/08/09 18:05:33, sadrul wrote: > ...
8 years, 4 months ago (2012-08-13 23:26:17 UTC) #3
sadrul
LGTM http://codereview.chromium.org/10825264/diff/5001/chrome/browser/chromeos/system/ash_system_tray_delegate.cc File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right): http://codereview.chromium.org/10825264/diff/5001/chrome/browser/chromeos/system/ash_system_tray_delegate.cc#newcode716 chrome/browser/chromeos/system/ash_system_tray_delegate.cc:716: virtual void SetVolumeControlDelegate( SetVolumeControlDelegate doesn't seem to be ...
8 years, 4 months ago (2012-08-14 18:12:52 UTC) #4
jennyz
Adding owner review. http://codereview.chromium.org/10825264/diff/5001/chrome/browser/chromeos/system/ash_system_tray_delegate.cc File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right): http://codereview.chromium.org/10825264/diff/5001/chrome/browser/chromeos/system/ash_system_tray_delegate.cc#newcode716 chrome/browser/chromeos/system/ash_system_tray_delegate.cc:716: virtual void SetVolumeControlDelegate( On 2012/08/14 18:12:52, ...
8 years, 4 months ago (2012-08-14 18:15:30 UTC) #5
sadrul
> yes, I think your suggestion is reasonable. Now I move the VolumeControlDelegate > to ...
8 years, 4 months ago (2012-08-14 18:18:17 UTC) #6
sky
LGTM with the following fix http://codereview.chromium.org/10825264/diff/5001/ash/system/tray/system_tray_delegate.h File ash/system/tray/system_tray_delegate.h (right): http://codereview.chromium.org/10825264/diff/5001/ash/system/tray/system_tray_delegate.h#newcode274 ash/system/tray/system_tray_delegate.h:274: virtual VolumeControlDelegate* volume_control_delegate() const ...
8 years, 4 months ago (2012-08-14 20:09:57 UTC) #7
jennyz
http://codereview.chromium.org/10825264/diff/5001/ash/system/tray/system_tray_delegate.h File ash/system/tray/system_tray_delegate.h (right): http://codereview.chromium.org/10825264/diff/5001/ash/system/tray/system_tray_delegate.h#newcode274 ash/system/tray/system_tray_delegate.h:274: virtual VolumeControlDelegate* volume_control_delegate() const = 0; On 2012/08/14 20:09:57, ...
8 years, 4 months ago (2012-08-14 21:12:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/10825264/3017
8 years, 4 months ago (2012-08-14 21:12:39 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 23:34:26 UTC) #10
Change committed as 151607

Powered by Google App Engine
This is Rietveld 408576698