Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7048)

Unified Diff: chrome/browser/ui/webui/chromeos/system_info_ui.cc

Issue 10825260: Fix about:system output. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/system_info_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/system_info_ui.cc b/chrome/browser/ui/webui/chromeos/system_info_ui.cc
index 9b4104d9d566d38a64f7f18f51fee7ee1df352a5..d4890f61f5ea5b97ed21900b91543772bdccfbee 100644
--- a/chrome/browser/ui/webui/chromeos/system_info_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/system_info_ui.cc
@@ -171,6 +171,13 @@ void SystemInfoUIHTMLSource::RequestComplete() {
chromeos::system::LogDictionaryType::iterator it;
for (it = logs_->begin(); it != logs_->end(); ++it) {
DictionaryValue* val = new DictionaryValue;
+ // Skip the 'debugd' key; this is a duplicate of all the logs that
+ // we're already getting from the debugd daemon. This will be fixed
+ // with http://code.google.com/p/chromium/issues/detail?id=138582
+ // which incidentally will also remove this code.
+ if (it->first == "debugd")
+ continue;
+
val->SetString("stat_name", it->first);
val->SetString("stat_value", it->second);
details->Append(val);
@@ -181,12 +188,7 @@ void SystemInfoUIHTMLSource::RequestComplete() {
chromeos::system::SysInfoResponse::iterator it;
for (it = sys_info_->begin(); it != sys_info_->end(); ++it) {
DictionaryValue* val = new DictionaryValue;
- // Prefix stats coming from debugd with 'debugd-' for now. The code that
- // displays stats can only handle one stat with a given name, so this
- // prevents names from overlapping. Once the duplicates have been
- // removed from userfeedback's list by
- // <https://gerrit.chromium.org/gerrit/25106>, the prefix can go away.
- val->SetString("stat_name", "debugd-" + it->first);
+ val->SetString("stat_name", it->first);
val->SetString("stat_value", it->second);
details->Append(val);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698