Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 10825260: Fix about:system output. (Closed)

Created:
8 years, 4 months ago by rkc
Modified:
8 years, 4 months ago
Reviewers:
xiyuan, Elly Fong-Jones
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix about:system output. Currently we have the debugd logs prefixed with debugd and then duplicated in another key called debugd; this will be fixed with http://code.google.com/p/chromium/issues/detail?id=138582 but for M22, we want to fix the UI to display the logs more appropriately. Reviews requested, ellyjones@ - main review. xiyuan@ - OWNER's review. R=ellyjones@chromium.org,xiyuan@chromium.org BUG=140489 TEST=debugd- prefixed keys are gone; so is the debugd key which contained all the logs again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/ui/webui/chromeos/system_info_ui.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rkc
8 years, 4 months ago (2012-08-08 22:14:27 UTC) #1
xiyuan
lgtm
8 years, 4 months ago (2012-08-08 23:01:19 UTC) #2
Elly Fong-Jones
lgtm LGTM
8 years, 4 months ago (2012-08-09 14:57:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10825260/1
8 years, 4 months ago (2012-08-09 18:31:07 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 20:30:38 UTC) #5
Change committed as 150882

Powered by Google App Engine
This is Rietveld 408576698