Issue 10825259: Use WebKit Platform API header locations instead of client API

Issue 10825259: Use WebKit Platform API header locations instead of client API (Closed)

Created:
8 years, 4 months ago by jamesr

Modified:
8 years, 4 months ago

Reviewers:
piman

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use WebKit Platform API header locations instead of client API This cuts down on the possible include paths for compositor. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150747

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
M	ui/compositor/DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/compositor/compositor.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/compositor/test/test_suite.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/compositor/test_web_graphics_context_3d.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

piman

Trybots say you want to fix test files too, but other than that LGTM

8 years, 4 months ago (2012-08-08 22:43:48 UTC) #2

jamesr

As it turns out compositor_test_support will still need to use WebKit.h from the client API, ...

8 years, 4 months ago (2012-08-08 23:31:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10825259/7003

8 years, 4 months ago (2012-08-09 00:30:17 UTC) #4

commit-bot: I haz the power

Try job failure for 10825259-7003 (retry) on linux_rel for step "nacl_integration". It's a second try, ...

8 years, 4 months ago (2012-08-09 01:45:53 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10825259/7003

8 years, 4 months ago (2012-08-09 04:06:04 UTC) #6

Change committed as 150747