Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 10825257: Remove metrics collection from Kiosk Mode. (Closed)

Created:
8 years, 4 months ago by rkc
Modified:
8 years, 4 months ago
Reviewers:
satorux1, sky
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove metrics collection from Kiosk Mode. Metrics collection for KioskMode has been replaced by data pulled from Analytics. Remove the current metrics reporting since it's broken and bloat. Reviews requested: satorux@ - Main reivew + OWNER's review for ChromeOS sky@ - OWNER's review for everything else :) R=satorux@chromium.org,sky@chromium.org BUG=126878 TEST=Kiosk mode works as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -118 lines) Patch
D chrome/browser/chromeos/kiosk_mode/kiosk_mode_metrics.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/chromeos/kiosk_mode/kiosk_mode_metrics.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/chromeos/login/login_performer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rkc
8 years, 4 months ago (2012-08-08 21:33:36 UTC) #1
satorux1
Less code is great! LGTM
8 years, 4 months ago (2012-08-08 21:46:28 UTC) #2
sky
LGTM
8 years, 4 months ago (2012-08-08 22:15:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10825257/1
8 years, 4 months ago (2012-08-08 22:16:35 UTC) #4
commit-bot: I haz the power
Try job failure for 10825257-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-08 22:56:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10825257/1
8 years, 4 months ago (2012-08-08 23:03:35 UTC) #6
commit-bot: I haz the power
Try job failure for 10825257-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-08 23:32:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10825257/1
8 years, 4 months ago (2012-08-08 23:38:00 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 00:48:46 UTC) #9
Change committed as 150657

Powered by Google App Engine
This is Rietveld 408576698