Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 10825256: Fixed issue displaying print preview on Windows XP. (Closed)

Created:
8 years, 4 months ago by gene
Modified:
8 years, 4 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed issue displaying print preview on Windows XP. Lack of XPS system on XP caused problems getting printer capabilities. Use default settings for print preview in this case. BUG=140044 TEST=On Windows XP (vanila install, no extras) go to a webpage and press Ctrl-P to bring up print preview. It should work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M chrome/browser/printing/print_system_task_proxy.cc View 2 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gene
8 years, 4 months ago (2012-08-08 21:29:36 UTC) #1
Albert Bodenhamer
lgtm
8 years, 4 months ago (2012-08-08 21:50:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10825256/1
8 years, 4 months ago (2012-08-08 23:43:51 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 02:09:46 UTC) #4
Change committed as 150683

Powered by Google App Engine
This is Rietveld 408576698