Expose memory allocator internal stats and properties.

base/allocator/allocator_extension_thunks.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_ALLOCATOR_ALLOCATOR_THUNKS_EXTENSION_H
 #define BASE_ALLOCATOR_ALLOCATOR_THUNKS_EXTENSION_H
 
+#include <stddef.h> // for size_t
+
 namespace base {
 namespace allocator {
 namespace thunks {
 
 // WARNING: You probably don't want to use this file unless you are routing a
 // new allocator extension from a specific allocator implementation to base.
 // See allocator_extension.h to see the interface that base exports.
 
+typedef bool GetPropertyFunction(const char*, size_t*);

[jar (doing other things), 2012/08/11 03:39:46]

nit: I think you should provide variable names for the args.

It is not clear why we picked up the (older) TCMalloc style here... and we're
writing prototypes without var names, etc. etc.

I think this is Chrome only code... so despite linking to TCMalloc, we should
probably comply with our style guide.

Personally, I'd also rather see a typedef for a pointer to function... as it is
jarring to see a typedef for a function.

I'd rather see:

typedef bool (*GetPropertyFunction)(const char* name, size_t * value);

with the related changes on next lines (and in cc files).

...but that is personal... and I can't see style-guide support.

I also see the existing code used that style... so if you are in any way
convinced, you should probably change them all to be consistent.

[alexeif, 2012/08/11 11:19:55]

Done.

+void SetGetPropertyFunction(GetPropertyFunction* get_property_function);
+GetPropertyFunction* GetGetPropertyFunction();
+
 typedef void GetStatsFunction(char*, int);
 void SetGetStatsFunction(GetStatsFunction* get_stats_function);
 GetStatsFunction* GetGetStatsFunction();
 
 typedef void ReleaseFreeMemoryFunction();
 void SetReleaseFreeMemoryFunction(
     ReleaseFreeMemoryFunction* release_free_memory_function);
 ReleaseFreeMemoryFunction* GetReleaseFreeMemoryFunction();
 
 }  // namespace thunks
 }  // namespace allocator
 }  // namespace base
 
 #endif