Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 10825245: AccelerometerMac::GetOrientation(): Fix return statement. (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
Reviewers:
Satish, aousterh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

AccelerometerMac::GetOrientation(): Fix return statement. We need to call release() on the scoped_refptr, otherwise it will destroy the underlying object. BUG=141041 TEST=used macbook to navigate to page using device orientation and didn't crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/device_orientation/accelerometer_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
8 years, 4 months ago (2012-08-08 13:22:18 UTC) #1
aousterh
LGTM
8 years, 4 months ago (2012-08-08 13:24:34 UTC) #2
Satish
LGTM Please look into returning the object as a scoped_refptr instead of raw pointer in ...
8 years, 4 months ago (2012-08-08 13:32:05 UTC) #3
hans
On 2012/08/08 13:32:05, Satish wrote: > LGTM > > Please look into returning the object ...
8 years, 4 months ago (2012-08-08 13:32:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10825245/1
8 years, 4 months ago (2012-08-08 13:32:50 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 15:13:34 UTC) #6
Change committed as 150556

Powered by Google App Engine
This is Rietveld 408576698