Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2177)

Unified Diff: chrome/browser/ui/gtk/extensions/shell_window_gtk.h

Issue 10825240: Refactor ShellWindow to separate platform-specific code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/extensions/shell_window.cc ('k') | chrome/browser/ui/gtk/extensions/shell_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/extensions/shell_window_gtk.h
diff --git a/chrome/browser/ui/gtk/extensions/shell_window_gtk.h b/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
index 432edd14c938c239c743303f5c6d4a58cc75c23d..ec20c655ac751222f32f5e5150ebc4c328321bd4 100644
--- a/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
+++ b/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
@@ -7,6 +7,7 @@
#include <gtk/gtk.h>
+#include "chrome/browser/ui/extensions/native_shell_window.h"
#include "chrome/browser/ui/extensions/shell_window.h"
#include "chrome/browser/ui/gtk/extensions/extension_view_gtk.h"
#include "ui/base/gtk/gtk_signal.h"
@@ -19,14 +20,12 @@ namespace extensions {
class Extension;
}
-class ShellWindowGtk : public ShellWindow,
+class ShellWindowGtk : public NativeShellWindow,
public ExtensionViewGtk::Container,
public ui::ActiveWindowWatcherXObserver {
public:
- ShellWindowGtk(Profile* profile,
- const extensions::Extension* extension,
- const GURL& url,
- const CreateParams& params);
+ ShellWindowGtk(ShellWindow* shell_window,
+ const ShellWindow::CreateParams& params);
// BaseWindow implementation.
virtual bool IsActive() const OVERRIDE;
@@ -52,9 +51,17 @@ class ShellWindowGtk : public ShellWindow,
virtual void ActiveWindowChanged(GdkWindow* active_window) OVERRIDE;
private:
- // ShellWindow implementation.
+ // NativeShellWindow implementation.
virtual void SetFullscreen(bool fullscreen) OVERRIDE;
virtual bool IsFullscreenOrPending() const OVERRIDE;
+ virtual void UpdateWindowTitle() OVERRIDE;
+
+ content::WebContents* web_contents() const {
+ return shell_window_->web_contents();
+ }
+ const extensions::Extension* extension() const {
+ return shell_window_->extension();
+ }
virtual ~ShellWindowGtk();
@@ -65,6 +72,8 @@ class ShellWindowGtk : public ShellWindow,
CHROMEGTK_CALLBACK_1(ShellWindowGtk, gboolean, OnWindowState,
GdkEventWindowState*);
+ ShellWindow* shell_window_; // weak - ShellWindow owns NativeShellWindow.
+
GtkWindow* window_;
GdkWindowState state_;
« no previous file with comments | « chrome/browser/ui/extensions/shell_window.cc ('k') | chrome/browser/ui/gtk/extensions/shell_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698