Refactor ShellWindow to separate platform-specific code.

chrome/browser/ui/views/extensions/shell_window_views.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_SHELL_WINDOW_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_SHELL_WINDOW_VIEWS_H_
 
+#include "chrome/browser/ui/base_window.h"
+#include "chrome/browser/ui/extensions/native_shell_window.h"
 #include "chrome/browser/ui/extensions/shell_window.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/scoped_sk_region.h"
 #include "ui/views/widget/widget_delegate.h"
 
 class Profile;
 
+namespace content {
+class WebContents;
+}
+
 namespace extensions {
 class Extension;
 struct DraggableRegion;
 }
 
 namespace views {
 class WebView;
 }
 
-class ShellWindowViews : public ShellWindow,
+class ShellWindowViews : public NativeShellWindow,
                          public views::WidgetDelegateView {
  public:
-  ShellWindowViews(Profile* profile,
-                   const extensions::Extension* extension,
-                   const GURL& url,
-                   const CreateParams& params);
+  ShellWindowViews(ShellWindow* shell_window,
+                   const ShellWindow::CreateParams& params);
 
   bool frameless() const { return frameless_; }
   SkRegion* draggable_region() { return draggable_region_.Get(); }
 
   // BaseWindow implementation.
   virtual bool IsActive() const OVERRIDE;
   virtual bool IsMaximized() const OVERRIDE;
   virtual bool IsMinimized() const OVERRIDE;
   virtual bool IsFullscreen() const OVERRIDE;
   virtual gfx::NativeWindow GetNativeWindow() OVERRIDE;
@@ skipping 25 matching lines @@
 
  protected:
   // views::View implementation.
   virtual void Layout() OVERRIDE;
   virtual void ViewHierarchyChanged(
       bool is_add, views::View *parent, views::View *child) OVERRIDE;
   virtual gfx::Size GetMinimumSize() OVERRIDE;
   virtual gfx::Size GetMaximumSize() OVERRIDE;
   virtual void OnFocus() OVERRIDE;
 
-  // ShellWindow implementation.
+  // NativeShellWindow implementation.
   virtual void UpdateWindowTitle() OVERRIDE;
   virtual void SetFullscreen(bool fullscreen) OVERRIDE;
   virtual bool IsFullscreenOrPending() const OVERRIDE;
 
+  virtual Profile* profile() { return shell_window_->profile(); }
+  virtual content::WebContents* web_contents() {

[tfarina, 2012/08/09 16:20:20]

Does these needs to be virtual? In any case, virtual functions should be named
CamelCase (e.g., GetWebContents). unix_hacker style is for inlined trivial
methods. 

[jeremya, 2012/08/09 23:59:53]

Not really :)

+    return shell_window_->web_contents();
+  }
+  virtual const extensions::Extension* extension() {
+    return shell_window_->extension();
+  }
+
  private:
   friend class ShellWindowFrameView;
 
   virtual ~ShellWindowViews();
 
   // content::WebContentsDelegate implementation.
   virtual void UpdateDraggableRegions(
       const std::vector<extensions::DraggableRegion>& regions) OVERRIDE;
 
   void OnViewWasResized();
 
   views::WebView* web_view_;
   views::Widget* window_;
   bool is_fullscreen_;
 
   gfx::ScopedSkRegion draggable_region_;
 
   bool frameless_;
   gfx::Size minimum_size_;
   gfx::Size maximum_size_;
 
+  ShellWindow* shell_window_;
+
   DISALLOW_COPY_AND_ASSIGN(ShellWindowViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_SHELL_WINDOW_VIEWS_H_