Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10825233: OnPointerMessage no longer nukes the active focus (Win8/Desktop). (Closed)

Created:
8 years, 4 months ago by girard
Modified:
8 years, 3 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disable force focus call from pointer events in Chrome/Win/Desktop This code was added in an attempt to make the on-screen-keyboard function in desktop chrome. By coincidence, it messes up popup menus/drop-down boxes. Removing the code. Issue 105637 tracks the OSK issue. We'll need to revisit/re-enable this code when we work on that. BUG=139420 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158173

Patch Set 1 #

Patch Set 2 : Cleaned up patch to use #if 0 #

Patch Set 3 : Removed dead code. #

Patch Set 4 : Removed OnPointerEvent entirely. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
girard
8 years, 3 months ago (2012-09-20 16:02:03 UTC) #1
sky
Ananta has been tweaking this code, he should look at this too. If we're going ...
8 years, 3 months ago (2012-09-20 19:29:17 UTC) #2
girard
On 2012/09/20 19:29:17, sky wrote: > Ananta has been tweaking this code, he should look ...
8 years, 3 months ago (2012-09-21 02:29:33 UTC) #3
girard
As per sky's comment, I've removed the dead code.
8 years, 3 months ago (2012-09-21 13:41:40 UTC) #4
sky
Again, Anata needs to comment on this as he has other patches in this area.
8 years, 3 months ago (2012-09-21 16:19:32 UTC) #5
ananta
On 2012/09/21 16:19:32, sky wrote: > Again, Anata needs to comment on this as he ...
8 years, 3 months ago (2012-09-21 17:01:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/10825233/4003
8 years, 3 months ago (2012-09-21 17:30:24 UTC) #7
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/render_widget_host_view_win.cc: While running patch -p1 --forward --force; patching file content/browser/renderer_host/render_widget_host_view_win.cc ...
8 years, 3 months ago (2012-09-21 17:30:25 UTC) #8
sky
LGTM
8 years, 3 months ago (2012-09-21 18:34:00 UTC) #9
girard
Minor update. After the submit hit a merge conflict, I rebased and found out that ...
8 years, 3 months ago (2012-09-21 18:38:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/10825233/4007
8 years, 3 months ago (2012-09-21 18:53:52 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-21 20:53:42 UTC) #12
girard
On 2012/09/21 20:53:42, I haz the power (commit-bot) wrote: > Sorry for I got bad ...
8 years, 3 months ago (2012-09-22 02:28:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/girard@chromium.org/10825233/4007
8 years, 3 months ago (2012-09-22 02:28:46 UTC) #14
commit-bot: I haz the power
8 years, 3 months ago (2012-09-22 06:16:34 UTC) #15
Change committed as 158173

Powered by Google App Engine
This is Rietveld 408576698