Clean-up safe browsing dependencies.

Clean-up safe browsing dependencies.

Rather than excluding safe_browsing dependencies for non-safe_browsing
builds only include them when needed. This is a baby-step towards a
safe_browsing component.

This is part of Android upstreaming (smhasher isn't used).

BUG=137571
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150846

[Ben Goodger (Google), 2012-08-07 18:05:35]

So I think this goes against a convention we have in chromium gyp files to list
everything for all platforms in the initial sources list, and exclude later.
Maybe Mark can comment more or validate this.

[Mark Mentovai, 2012-08-07 18:07:09]

Ben is right. List everything in sources, exclude the things you don’t want in
sources! or sources/. That keeps all of the files visible, but not compiled, in
generated project files, making it easy for others to work on those files.

[Ben Goodger (Google), 2012-08-07 18:09:56]

There are a bunch of tricks employed to make this easier en masse:

. for platforms, we exclude _win/_mac/_gtk etc depending on circumstance
. for some configurations, we exclude whole subdirs, e.g. if toolkit_views==0,
don't build chrome/browser/ui/views
. we've been trying to move towards a world where isolated features are
components with their own gyp files/dirs, so they can be built only if they are
needed.

A directory exclusion is probably the simplest thing to do here, but that's what
the code was doing before.

[Yaron, 2012-08-07 18:23:29]

Hrmm. I liked the idea of grouping everything in one place and I thought this
was a small step towards being a component but I understand that since it's not
split off yet, it should remain in the one source list. However, the
dependencies are still only included in the event of a safe browsing build which
I've seen elsewhere (and it'd be a gyp failure otherwise).

[Yaron, 2012-08-08 22:28:49]

bump. still needs a review as I want the dep change

[Ben Goodger (Google), 2012-08-09 15:38:44]

lgtm

[Mark Mentovai, 2012-08-09 15:39:31]

LGTM

[commit-bot: I haz the power, 2012-08-09 16:33:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10825226/6001

[commit-bot: I haz the power, 2012-08-09 18:04:00]

Change committed as 150846