Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 10825225: Fix clang warning in sqlite shell_icu_linux.c. (Closed)

Created:
8 years, 4 months ago by Scott Hess - ex-Googler
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Fix clang warning in sqlite shell_icu_linux.c. Add include file per bug. BUG=138571 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M third_party/sqlite/icu-shell.patch View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/sqlite/src/src/shell_icu_linux.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Scott Hess - ex-Googler
Diff header changed because I'm using git these days ... I just patched in the ...
8 years, 4 months ago (2012-08-07 17:38:22 UTC) #1
Nico
lgtm Thanks!
8 years, 4 months ago (2012-08-07 17:54:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10825225/1
8 years, 4 months ago (2012-08-07 18:00:27 UTC) #3
commit-bot: I haz the power
Try job failure for 10825225-1 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 4 months ago (2012-08-07 19:26:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10825225/1
8 years, 4 months ago (2012-08-07 19:29:46 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 21:21:49 UTC) #6
Change committed as 150415

Powered by Google App Engine
This is Rietveld 408576698