Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2923)

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 10825221: views: Use Tab pointer directly when calling TabStrip::tab_at. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab_strip.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
index 7ddbd68b075c51f85321b301bd8e0b97e0b14e28..dd7b8ccaa75af398829a9be96359a1a447e59c36 100644
--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
@@ -292,8 +292,8 @@ void BrowserTabStripController::UpdateLoadingAnimations() {
// before we've applied an update from the model (Browser::TabInsertedAt may
// be processed before us and invokes this).
for (int i = 0, tab_count = tabstrip_->tab_count(); i < tab_count; ++i) {
- BaseTab* tab = tabstrip_->tab_at(i);
if (model_->ContainsIndex(i)) {
+ Tab* tab = tabstrip_->tab_at(i);
TabContents* contents = model_->GetTabContentsAt(i);
tab->UpdateLoadingAnimation(
TabContentsNetworkState(contents->web_contents()));
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab_strip.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698