Issue 10825221: views: Use Tab pointer directly when calling TabStrip::tab_at.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825221: views: Use Tab pointer directly when calling TabStrip::tab_at. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Use Tab pointer directly when calling TabStrip::tab_at. We can use Tab* directly instead of using the base class BaseTab*, because that is what tab_at returns and Tab is a subclass of BaseTab. This is a work towards on merging BaseTab into Tab, which is also a TODO. R=sky@chromium.org NOTRY=True Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150786

Patch Set 1 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/views/tabs/tab_strip.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10825221/2001

8 years, 4 months ago (2012-08-09 12:16:51 UTC) #3

Change committed as 150786

Expand Messages | Collapse Messages