Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: chrome/browser/debugger/devtools_window.cc

Issue 10825217: Revert "Make F12 close an undocked DevTools window rather than open another DevTools window for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_window.h ('k') | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_window.cc
diff --git a/chrome/browser/debugger/devtools_window.cc b/chrome/browser/debugger/devtools_window.cc
index 97c97c04ba3927f624248d5873e7aa08c99694ec..536b3b6e0a73c4470f11fe742a5282dc4c385273 100644
--- a/chrome/browser/debugger/devtools_window.cc
+++ b/chrome/browser/debugger/devtools_window.cc
@@ -103,7 +103,15 @@ TabContents* DevToolsWindow::GetDevToolsContents(WebContents* inspected_tab) {
// static
bool DevToolsWindow::IsDevToolsWindow(RenderViewHost* window_rvh) {
- return AsDevToolsWindow(window_rvh) != NULL;
+ if (g_instances == NULL)
+ return false;
+ DevToolsWindowList& instances = g_instances.Get();
+ for (DevToolsWindowList::iterator it = instances.begin();
+ it != instances.end(); ++it) {
+ if ((*it)->tab_contents_->web_contents()->GetRenderViewHost() == window_rvh)
+ return true;
+ }
+ return false;
}
// static
@@ -608,14 +616,6 @@ DevToolsWindow* DevToolsWindow::ToggleDevToolsWindow(
RenderViewHost* inspected_rvh,
bool force_open,
DevToolsToggleAction action) {
- if (!force_open) {
- DevToolsWindow* currentDevToolsWindow = AsDevToolsWindow(inspected_rvh);
- if (currentDevToolsWindow) {
- chrome::CloseAllTabs(currentDevToolsWindow->browser());
- return currentDevToolsWindow;
- }
- }
-
DevToolsAgentHost* agent = DevToolsAgentHostRegistry::GetDevToolsAgentHost(
inspected_rvh);
DevToolsManager* manager = DevToolsManager::GetInstance();
@@ -663,19 +663,6 @@ DevToolsWindow* DevToolsWindow::AsDevToolsWindow(
return NULL;
}
-// static
-DevToolsWindow* DevToolsWindow::AsDevToolsWindow(RenderViewHost* rvh) {
- if (g_instances == NULL)
- return NULL;
- DevToolsWindowList& instances = g_instances.Get();
- for (DevToolsWindowList::iterator it = instances.begin();
- it != instances.end(); ++it) {
- if ((*it)->tab_contents_->web_contents()->GetRenderViewHost() == rvh)
- return *it;
- }
- return NULL;
-}
-
void DevToolsWindow::ActivateWindow() {
if (!docked_) {
if (!browser_->window()->IsActive()) {
« no previous file with comments | « chrome/browser/debugger/devtools_window.h ('k') | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698