Issue 10825217: Revert "Make F12 close an undocked DevTools window rather than open another DevTools window for thi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825217: Revert "Make F12 close an undocked DevTools window rather than open another DevTools window for thi… (Closed)

Created:
8 years, 4 months ago by apavlov

Modified:
8 years, 4 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Make F12 close an undocked DevTools window rather than open another DevTools window for this one." We decided to revert the change, since it breaks user experience a lot of clients are used to. This reverts commit 30f6403d845caf5683080a3bd5048d9a18286b88. BUG=139581 TBR=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150301

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -30 lines)			Patch
M	chrome/browser/debugger/devtools_window.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_window.cc	View	3 chunks	+9 lines, -22 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download